Conversation
amirbey
force-pushed
the
amirbey/LG-11427-add-hybrid-flow-to-analytics-events-spec
branch
from
c1bb614 to
55e1abc
Compare
spec/features/idv/analytics_spec.rb
Outdated
|
|
||
| it 'records all of the events' do | ||
| aggregate_failures 'analytics events' do | ||
| happy_path_events.each do |event, attributes| |
There was a problem hiding this comment.
| happy_path_events.each do |event, attributes| | |
| happy_hybrid_path_events.each do |event, attributes| |
charleyf
left a comment
charleyf
left a comment
There was a problem hiding this comment.
This looks like a good reuse of the existing happy path spec code. I didn't examine it beyond checking that the flow of the test made sense to me.
One suggestion below that will make the tests pass, looks like a missed find/change.
| end | ||
| end | ||
|
|
||
| it 'records all of the events' do |
There was a problem hiding this comment.
We can also reuse this for hybrid or non hybrid happy path as shared example, but not a blocker.
LGTM.
|
I was hoping this might include the "Link sent capture doc polling started" event, which #9481 touches. Is that possible? Not sure if there's going to be some timing issues between when the JavaScript runs and how quickly the test completes. |
yes. i did try adding the polling events but there may be a Javascript timing issue like you mentioned 🤔 |
amirbey
deleted the
amirbey/LG-11427-add-hybrid-flow-to-analytics-events-spec
branch
4 participants
🎫 Ticket
LG-11427
🛠 Summary of changes
Add hybrid flow test to analytics spec