LG 11141 Break up MFA selection presenter classes for Backup codes#9532
Merged
kevinsmaster5 merged 6 commits intomainfrom Nov 6, 2023
Merged
LG 11141 Break up MFA selection presenter classes for Backup codes#9532kevinsmaster5 merged 6 commits intomainfrom
kevinsmaster5 merged 6 commits intomainfrom
Conversation
kevinsmaster5
force-pushed
the
kmas-lg-11141-break-up-backup-code-presenter
branch
from
324f7fd to
a59bb74
Compare
jmdembe
reviewed
Nov 3, 2023
| case type | ||
| when 'backup_code' | ||
| t('two_factor_authentication.login_options.backup_code') | ||
| when 'personal_key' |
Contributor
There was a problem hiding this comment.
Are we changing backup_code to personal_key permanently?
Contributor
Author
There was a problem hiding this comment.
Not as such. I think personal_key gets removed from this switch statement on a different branch that's ahead of mine. Those label cases are moved to their respective set up/sign in selection presenter. I'll double check to make sure I'm not somehow adding that back in.
It should be gone from line ~72 as of this PR #9528
Contributor
There was a problem hiding this comment.
There may have been a merge conflict where the personal_key statement got added back accidentally. I wouldn't expect it to be here.
Contributor
Author
There was a problem hiding this comment.
I have removed that from my branch.
kevinsmaster5
deleted the
kmas-lg-11141-break-up-backup-code-presenter
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11141
🛠 Summary of changes
Divide Backup codes presenter classes into Sign In and Sign Up classes following the example of #9211
📜 Testing Plan