Amirbey/fix missing attributes in frontend events

[amirbey]

🛠 Summary of changes

Re-add attributes for analytics events.

[aduth]

Just want to flag that these renames will now fail build as of #9539. Renaming an event is a good opportunity to adopt the new naming scheme.

These should be :idv_clicked_sp_link_on_ready_to_verify_page and :idv_clicked_what_to_bring_link_on_ready_to_verify_page now if we're okay to do a rename.

[amirbey]

thanks Andrew .. removed this unused method as we discussed 👍🏿

[mitchellhenke]

I think this one was translated incorrectly by me to begin with and should not have included the Frontend prefix?

[aduth]

@mitchellhenke I think we didn't need the method you added, it was already wired up to an existing analytics method that doesn't have the prefix. The method you added was effectively dead code.

identity-idp/app/controllers/frontend_log_controller.rb

Line 39 in 5209813

'IdV: user clicked what to bring link on ready to verify page' => :idv_in_person_ready_to_verify_what_to_bring_link_clicked,

identity-idp/app/services/analytics_events.rb

Lines 1826 to 1832 in 5209813

	# The user clicked the what to bring link on the "ready to verify" page
	def idv_in_person_ready_to_verify_what_to_bring_link_clicked(**extra)
	track_event(
	'IdV: user clicked what to bring link on ready to verify page',
	**extra,
	)
	end

[mitchellhenke]

ahhhh, thanks