LG-11144: Refactor Personal Key selection presenter as sign-in selection#9528
Merged
LG-11144: Refactor Personal Key selection presenter as sign-in selection#9528
Conversation
changelog: Internal, Code Quality, Refactor sign in selection presenters
kevinsmaster5
approved these changes
Nov 3, 2023
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good! I tested locally and didn't encounter any problems.
aduth
changed the title
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11144
🛠 Summary of changes
Adapts personal key selection presenter to new convention of SetUp/SignIn-specific presenters.
Since we no not offer personal key as an MFA for setup, this largely consists of a rename of the existing presenter.
📜 Testing Plan
Build should pass
Test the sign-in flow for personal key. See #8531 Testing Plan for reference to emulating an account with personal key MFA support.