Conversation
changelog: Internal, Performance, Reduce size of application stylesheet
Makefile
Outdated
| # This enforces an asset size budget to ensure that download sizes are reasonable and to protect | ||
| # against accidentally importing large pieces of third-party libraries. If you're here debugging a | ||
| # failing build, check to ensure that you've not added more JavaScript or CSS than necessary, and | ||
| # you have no options to split that from the main bundles. If you need to increase this budget and | ||
| # accept the fact that this will force end-users to endure longer load times, you should set the new | ||
| # budget to within a few thousand bytes of the current production-compiled size. |
There was a problem hiding this comment.
I'd expect we indent this comment? Like in the optimize_svg task?
There was a problem hiding this comment.
I'd expect we indent this comment? Like in the
optimize_svgtask?
Hmm for some reason I didn't think Make liked the syntax, but I see what you're saying about optimize_svg. Let me try again.
There was a problem hiding this comment.
maybe a tabs vs spaces issue? Makefiles are sensitive to the difference
There was a problem hiding this comment.
Okay, yeah, it's quite likely it was a spacing issue. That or I didn't like how it would output the comment to the terminal (not a huge deal, but 🤷 ). It's not pretty with all the @, but 4bb1045 updates so that it's indented and doesn't output the comment.
| renders_many :items, ->(**kwargs, &block) { | ||
| IconListItemComponent.new(icon:, color:, **kwargs, &block) | ||
| } |
There was a problem hiding this comment.
I feel like we mostly use do....end for multi-line blocks and I confirmed with ruby-parse that this gives us the same results (sometimes ommitting parens means the block gets passed to renders_many instead of to the proc)
| renders_many :items, ->(**kwargs, &block) { | |
| IconListItemComponent.new(icon:, color:, **kwargs, &block) | |
| } | |
| renders_many :items, ->(**kwargs, &block) do | |
| IconListItemComponent.new(icon:, color:, **kwargs, &block) | |
| end |
There was a problem hiding this comment.
Looks like we've got the do ... end syntax in StatusPageComponent, so I should expect that will work. I admit that I largely copied from ProcessListComponent for this, which uses the curly braces.
In 1f71d2e, I've updated them all to use the same multiline syntax.
2 participants
🛠 Summary of changes
Adds a new
IconListComponentcomponent implementation.Why?
📜 Testing Plan
Repeat testing instructions from #8863 to verify no regressions in the display of "Your authentication methods".
See component preview: