LG-11427 Frontend Logging for phone_with_camera#9481
Conversation
…brid handoff page
charleyf
changed the base branch from
main
to
amirbey/LG-11427-be-log-phone-with-camera
| { phone_question_ab_test_bucket: 'bypass_phone_question' }, | ||
| { | ||
| phone_question_ab_test_bucket: 'bypass_phone_question', | ||
| phone_with_camera: false, |
There was a problem hiding this comment.
I think this will need to be added to the attributes in the events where it's used
identity-idp/app/services/analytics_events.rb
Lines 2232 to 2236 in 9201a11
There was a problem hiding this comment.
I wonder if we should have a "hybrid" path or branch in spec/fetaures/idv/analytics_spec.rb to check for a more "real" usage. Between this and #9481 (comment), it doesn't seem like our current tests are giving us much assurance that these events are actually getting logged as expected.
amirbey
left a comment
amirbey
left a comment
There was a problem hiding this comment.
blocking to prevent approval and merge
phone_with_camera is not logging ... i have added logging for image clicked ... still debugging log requests
I suspect it is due to the comment here |
| acuant_sdk_upgrade_a_b_testing_variables, | ||
| phone_question_ab_test_analytics_bucket, | ||
| ) | ||
| ).merge(phone_with_camera) |
There was a problem hiding this comment.
| ).merge(phone_with_camera) | |
| phone_with_camera, | |
| ) |
| ab_test_analytics_buckets, | ||
| phone_with_camera, | ||
| ) | ||
| ).merge(phone_with_camera) |
There was a problem hiding this comment.
| ).merge(phone_with_camera) | |
| phone_with_camera, | |
| ) |
There was a problem hiding this comment.
Agreed that that makes sense, but when I tried this it caused tests to fail. I'm not sure why.
4 participants
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-11427
🛠 Summary of changes
This PR sends the new
phone_with_cameralogging value to the FE so we can include it in FE logs. This work can only be merged after the work in #9461 is merged and will need cleanup once that work merges. This work is based on #9400 which added the other values we need to the FE logging.📜 Testing Plan
Same testing plan as in #9400
make setuplog/events.logFrontend: IdV: Acuant SDK loadedevent has aphone_question_ab_test_bucketproperty.Frontend: IdV: front image clickedevent has aphone_question_ab_test_bucketproperty.Frontend: IdV: front image addedevent has aphone_question_ab_test_bucketproperty.Frontend: IdV: back image clickedevent has aphone_question_ab_test_bucketproperty.Frontend: IdV: back image clickedevent has aphone_question_ab_test_bucketproperty.Frontend: IdV: Link sent capture doc polling startedevent has aphone_question_ab_test_bucketproperty.Frontend: IdV: Link sent capture doc polling completeevent has aphone_question_ab_test_bucketproperty.