LG-11317 account ref string for sms

[JackRyan1989]

🎫 Ticket

🛠 Summary of changes

Added reference number to SMS message & translations. This number is simply the enrollment code.

📜 Testing Plan

1. Push branch to dev sandbox and create an enrollment there.
2. Have USPS pass the enrollment to trigger an SMS response.
3. Capture image of SMS message on phone.
4. Supply screen shots for design review.
5. Confirm translations.

[gina-yamada]

@JackRyan1989 Your French translation uses reference_number. Your other translation files use reference_string. Your test will pass when you change it

[gina-yamada]

Your code changes look good to me. Maybe overkill but what do you think about adding to tests for the English and Spanish version of the outgoing SMS (just because it is going out to our users- just to be really sure it reads as we'd expect)? If the variable for Spanish or English got mistyped it may have not been caught as it was a sneaky typo. I think lucky we tested in French. Ultimately up to you, I'd still approve if you disagree.

Is it possible to see screenshots/testing in joy before approving or does it need to happen in dev? (If dev, if you merge in right after a deployment on Thursday it might buy you some more time to test so that this does not make its way up to production as fast.) Also, when testing, an enrollment for each language would be nice.

[JackRyan1989]

Your code changes look good to me. Maybe overkill but what do you think about adding to tests for the English and Spanish version of the outgoing SMS (just because it is going out to our users- just to be really sure it reads as we'd expect)? If the variable for Spanish or English got mistyped it may have not been caught as it was a sneaky typo. I think lucky we tested in French. Ultimately up to you, I'd still approve if you disagree.

Is it possible to see screenshots/testing in joy before approving or does it need to happen in dev? Also, when testing, an enrollment for each language would be nice.

Totally. I'll add the english and spanish tests as well.

[gina-yamada]

Code changes look good. You are adding tests for Spanish and English soon.

[gina-yamada]

😍

[carmenrosalop]

LGTM!