Skip to content

Add Selfie to FE: Conditional Passiveliveness Script Load#9546

Merged
charleyf merged 7 commits intomainfrom
charley/add-acuant-passive-liveness-javascript-files
Nov 6, 2023
Merged

Add Selfie to FE: Conditional Passiveliveness Script Load#9546
charleyf merged 7 commits intomainfrom
charley/add-acuant-passive-liveness-javascript-files

Conversation

@charleyf
Copy link
Contributor

@charleyf charleyf commented Nov 3, 2023

🎫 Ticket

https://cm-jira.usa.gov/browse/LG-11377

🛠 Summary of changes

This is PR 2 of 3 that will meet the ACs of LG-11377

  1. #9536 Add the feature flag
  2. #9546 (this PR) Make AcuantPassiveLiveness available in the FE (loading the script).
  3. #9553 Add the selfie UI.

This PR loads the acuant passive liveness script when the feature flag is turned on. Otherwise the script is not loaded. More useful context is in this Slack thread.

📜 Testing Plan

Provide a checklist of steps to confirm the changes. Testing is dev only, since you have to force the feature flag on.

  • On desktop (or phone) Go to the page where you upload the front/back of the id.
  • Open your browser's dev tools, find the "sources" panel where it lists which JS scripts are loaded. You should see an AcuantCamera script and several others but not a AcuantPassiveLiveness script or a 'opencv' script.
  • Force the IdentityConfig.store.doc_auth_selfie_capture feature flag to be {:enabled: true}
  • Restart the application
  • Back to the dev tools, you should now see the AcuantPassiveLiveness script and an opencv script being loaded as well.

@charleyf charleyf marked this pull request as ready for review November 6, 2023 14:31
@charleyf charleyf requested review from a team and dawei-nava and removed request for a team November 6, 2023 14:32
Copy link
Contributor

@dawei-nava dawei-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight forward change, LGTM.

@charleyf charleyf merged commit 285cd35 into main Nov 6, 2023
@charleyf charleyf deleted the charley/add-acuant-passive-liveness-javascript-files branch November 6, 2023 19:19
@matthinz matthinz mentioned this pull request Nov 6, 2023
@charleyf charleyf mentioned this pull request Nov 17, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants