Merged
Conversation
* Avoid importing design system utilities into email CSS changelog: Internal, Performance, Improve email send performance by reducing stylesheet size Co-Authored-By: Mitchell Henke <1430443+mitchellhenke@users.noreply.github.com> * Add barcode styles to email stylesheet Co-authored-by: Mitchell Henke <1430443+mitchellhenke@users.noreply.github.com>
Removed IAL2_STRICT constant and then chased down and removed the things that depended on it. [skip changelog]
…7222) * LG-7876: Create rake task to insert a large number of enrollment records * LG-7876: Update task to be more realistic; start writing additional test * LG-7876: Ease and optimize repetitive usage of dev user/enrollment generation tasks * changelog: Internal, In-Person Proofing, Create CLI tool for generating in-person enrollments
* first pass of removing liveness & selfie from LN * removed liveness from true_id_request spec * fixed the specs for true_id_response * [skip changelog] * remove liveness from doc_auth router
* [skip changelog] * Make linter happy: comma and line length * Collapse process_results() function * Restore expected post_images args and set stub them to nil * Making code climate happy * Make linter happy * Test called "returns a passed result" should actually pass, I think * Remove liveness_enabled arg from doc_auth_router_spec * Per hooper add test of https://developers.login.gov/testing/#data-testing * Indentation
* Removing initial selfie related react code We are also provisionally updating tests. Here we have marked a few to skip temporarily so we can figure out what they are actually testing [skip changelog] * Culling more tests and references to selfie on frontend [skip changelog] * More cleanup [skip changelog] * Remove liveness enabled block * Remove unused variables * Remove more unused variables * Remove skipped test and unused variables * Remove unhandled submission failure test * Remove handled submission failure test * Remove async upload pending progress test * Remove onStepChange callback test * Delete use-focus-fallback-ref.js * Delete use-focus-fallback-ref-spec.jsx * Remove liveness checking enabled context * Remove unused translations * Remove capture prop * Remove selfie-related code * Remove capture prop from file input component * Remove capture prop pass * Remove unnecessary assignment * Remove capture prop and unnecessary test * Restore document capture tests * @aduth changes * Remove unused import Co-authored-by: Kimball Bighorse <kbighorse@yahoo.com>
* Add sassc error message troubleshooting and make lint * [skip changelog]
* LG-7810: Zero-pad SC ID numbers if < 8 digits changelog: Improvements, Identity Verification, Pad SC ID numbers with leading zeros if less than 8 digits. * simplify zero padding don't mutate the original PII Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * log the redacted state_id_number to capture format Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* changelog: Improvements, In-Person Proofing, ArcgisApi::Geocoder auth strategy changed * Update app/services/arcgis_api/geocoder.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
changelog: Internal, Performance, Improve email send performance by reducing stylesheet size
* Collapse language picker by default changelog: Bug Fixes, Page Layout, Avoid flickering language picker appearance on page load * Add spec for language picker accessible relation * Add spec for language options
…7229) \We are removing the selfie and strict IAL2 tooling 🙅. This commit moves us in that direction ➡️ by removing the distinction between selfie and no selfie general errors in the doc auth error generator. [skip changelog]
Added info box for IRS re-proofing. Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* LG-7686: Update address line 2 label for IPP address form changelog: Improvements, In-person proofing, Clarify "Address line 2" label for address form * Remove strings consistently across locales * Update spec label references
* changelog: Improvements, In-Person Proofing, ArcgisApi::Geocoder caches short-lived token * Rewrite token caching to be more succinct * Remove unused method * Remove unused method and add comments * Use symbol for cache key. Use memory cache for test env. * Update spec/rails_helper.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/services/arcgis_api/geocoder.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update config/environments/test.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Use better assertions for a test * Add some more assertions to tests Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This SVG is currently a blue cirle with a white 'i'. This commit makes it a white circle with a transparent 'i'. [skip changelog]
…en't used and have default values in images clients (#7235) This commit gives us some safety and assurance that things won't break when we start deploying the changes to remove IAL2 strict. All of the clients _should_ have a default arg for `selfie_image` and `liveness_checking_enabled` and none of the callers should be passing those args. We can follow this up with a commit to configure the clients to stop supporting those args. [skip changelog]
We are removing IAL2 strict and selfie match functionality. This commit cleans up the last references to the selfie match portions of the `ErrorGenerator`. The `ErrorGenerator` produces a takes the reponse and ultimately generates an errors hash data structure which can be used to render errors to the user on specific images (e.g. the front, back, selfie, or entire ID). This commit removes the code that covered special cases for selfie failures. [skip changelog]
Resolves LG-7878 changelog: Bug Fixes, Authentication, Remove invalid prompt to send user back to SP during OIDC logout
jskinne3
reviewed
Oct 31, 2022
Contributor
jskinne3
left a comment
jskinne3
left a comment
There was a problem hiding this comment.
It's tough to code review when all the subsequent git changes have been rebased on top of your work. Could you name the files that you actually want reviewed?
Contributor
Author
@jskinne3 This is a promotion pull request for a production deploy. I requested your review because one of your pull requests (#7227) is included in it. It doesn't require a thorough review since all of these commits have been approved in prior pull requests. For reference: https://handbook.login.gov/articles/appdev-deploy.html |
mitchellhenke
approved these changes
Oct 31, 2022
#7244) This is necessary to prevent a bug where the "Reproof for IRS" modal appeared when users where proofing with IRS for the first time. Also, this makes logical sense since a user who has not proofed before cannot reproof [skip changelog]
Contributor
Author
|
Added #7244 (4348005) by request (Slack context) |
mdiarra3
approved these changes
Oct 31, 2022
orenyk
approved these changes
Oct 31, 2022
NavaTim
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Bug Fixes
Internal
Upcoming Features