LG-7944 Return false from reproof_for_irs? if a user has never proofed#7244
Merged
LG-7944 Return false from reproof_for_irs? if a user has never proofed#7244
Conversation
This is necessary to prevent a bug where the "Reproof for IRS" modal appeared when users where proofing with IRS for the first time. Also, this makes logical sense since a user who has not proofed before cannot reproof
zachmargolis
approved these changes
Oct 28, 2022
| end | ||
|
|
||
| context 'an attempts API service provider' do | ||
| let(:service_provider) { create(:service_provider, :irs) } |
Contributor
There was a problem hiding this comment.
👀 I hadn't seen the :irs factory bit, neat!
aduth
pushed a commit
that referenced
this pull request
Oct 31, 2022
#7244) This is necessary to prevent a bug where the "Reproof for IRS" modal appeared when users where proofing with IRS for the first time. Also, this makes logical sense since a user who has not proofed before cannot reproof [skip changelog]
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary to prevent a bug where the "Reproof for IRS" modal appeared when users where proofing with IRS for the first time.
Also, this makes logical sense since a user who has not proofed before cannot reproof