Merged
Conversation
theabrad
commented
Oct 26, 2022
| :trueid_account_id, | ||
| :trueid_liveness_cropping_workflow, | ||
| :trueid_liveness_nocropping_workflow, | ||
| :trueid_noliveness_cropping_workflow, |
Contributor
Author
There was a problem hiding this comment.
these configs are still needed for acuant. should we rename them since liveness is taken out?
Contributor
There was a problem hiding this comment.
If these are used for Acuant, ideally we'll be getting rid of them when we move on to taking selfie out of that. It may not be worth renaming them if we are going to remove them.
aduth
reviewed
Oct 26, 2022
Comment on lines
8
to
9
| :trueid_noliveness_cropping_workflow, | ||
| :trueid_noliveness_nocropping_workflow, |
Contributor
There was a problem hiding this comment.
Can we simplify this to avoid references to liveness altogether?
Suggested change
| :trueid_noliveness_cropping_workflow, | |
| :trueid_noliveness_nocropping_workflow, | |
| :trueid_cropping_workflow, | |
| :trueid_nocropping_workflow, |
Contributor
There was a problem hiding this comment.
I think we could, but either the new config names will need to be promoted through all evns or we will need to have the name true id uses be out of sync.
jmhooper
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Why? Removed liveness and selfie from the LexisNexis client.