Conversation
…en't used and have default values in images clients This commit gives us some safety and assurance that things won't break when we start deploying the changes to remove IAL2 strict. All of the clients _should_ have a default arg for `selfie_image` and `liveness_checking_enabled` and none of the callers should be passing those args. We can follow this up with a commit to configure the clients to stop supporting those args.
3 tasks
theabrad
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit gives us some safety and assurance that things won't break when we start deploying the changes to remove IAL2 strict.
All of the clients should have a default arg for
selfie_imageandliveness_checking_enabledand none of the callers should be passing those args. We can follow this up with a commit to configure the clients to stop supporting those args.