Skip to content

Removed IAL2_STRICT constant#7220

Merged
jmax-gsa merged 8 commits intomainfrom
LG-7910-continue-removing-ial2-strict-api
Oct 26, 2022
Merged

Removed IAL2_STRICT constant#7220
jmax-gsa merged 8 commits intomainfrom
LG-7910-continue-removing-ial2-strict-api

Conversation

@jmax-gsa
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket.

🛠 Summary of changes

Write a brief description of what you changed.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1
  • Step 2
  • Step 3

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before:
After:

🚀 Notes for Deployment

Include any special instructions for deployment.

@jmax-gsa jmax-gsa force-pushed the LG-7910-continue-removing-ial2-strict-api branch from 35b326d to 8094e90 Compare October 25, 2022 20:45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider maybe deprecating this? # @deprecated or some other comment?

We have a few ServiceProviderIdentity rows that have ial = 22 in the DB in the int environment

ServiceProviderIdentity.where('ial > 2').pluck(:ial).tally
=> {3=>443, 22=>5}

On the other hand, int is not prod (and there are no IAL 22 in prod)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's not in prod could we downgrade the dev/int users to IAL 2?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaning just an update for everyone with IAL = 22 to make them IAL 2?

@jmax-gsa jmax-gsa force-pushed the LG-7910-continue-removing-ial2-strict-api branch from 3635f91 to e5c1b83 Compare October 26, 2022 15:39
Copy link
Contributor

@jmhooper jmhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should handle the IAL2 strict users in int before merging. But, once we do that this should be good to go!

@jmhooper
Copy link
Contributor

I just hopped on int and got rid of all the old IAL2-strict SP identities so this should be good to go

@jmax-gsa jmax-gsa force-pushed the LG-7910-continue-removing-ial2-strict-api branch from 688d57a to 405c668 Compare October 26, 2022 18:22
@jmax-gsa jmax-gsa marked this pull request as ready for review October 26, 2022 18:55
@jmax-gsa jmax-gsa merged commit 42473aa into main Oct 26, 2022
@jmax-gsa jmax-gsa deleted the LG-7910-continue-removing-ial2-strict-api branch October 26, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants