Skip to content

Remove selfie and liveness check from mock doc_auth client#7221

Merged
jskinne3 merged 10 commits intomainfrom
jskinne3-remove-liveness-from-DocAuth-Mock
Oct 26, 2022
Merged

Remove selfie and liveness check from mock doc_auth client#7221
jskinne3 merged 10 commits intomainfrom
jskinne3-remove-liveness-from-DocAuth-Mock

Conversation

@jskinne3
Copy link
Contributor

🎫 Ticket

LG-7711

🛠 Summary of changes

  • Remove selfie and liveness check from mock doc_auth client and relevant specs.
  • Put a NotImplementedError to a function that's needed when spec compares to mock client to Acuant client

hints: false,
back: [DocAuth::Errors::FALLBACK_FIELD_LEVEL],
front: [DocAuth::Errors::FALLBACK_FIELD_LEVEL],
general: [DocAuth::Errors::GENERAL_ERROR_NO_LIVENESS],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the right errors to expect here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case appears... contradictory. It's claiming that it's testing a passed result, but then asserting that it's unsuccessful?

I wonder if the input YAML is not set up correctly and is being treated as a failure (e.g. missing properties). Could we try pulling in a passed result like what we document and see if it would turn these values to a successful result?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The author of the test seems not sure which result they wanted to test. Per @jmhooper I used example .yaml files from our docs to split this test into two:

  • returns a passed result
  • returns caution result

Comment on lines +49 to +50
def post_selfie
raise NotImplementedError,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a spec that ensures this method is defined? if not, I would just delete it because we still get a NoMethodError when calling it, almost the same as NotImplementedError

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup there is

@jskinne3 jskinne3 merged commit 591166b into main Oct 26, 2022
@jskinne3 jskinne3 deleted the jskinne3-remove-liveness-from-DocAuth-Mock branch October 26, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants