Remove selfie and liveness check from mock doc_auth client#7221
Remove selfie and liveness check from mock doc_auth client#7221
Conversation
| hints: false, | ||
| back: [DocAuth::Errors::FALLBACK_FIELD_LEVEL], | ||
| front: [DocAuth::Errors::FALLBACK_FIELD_LEVEL], | ||
| general: [DocAuth::Errors::GENERAL_ERROR_NO_LIVENESS], |
There was a problem hiding this comment.
Are these the right errors to expect here?
There was a problem hiding this comment.
This test case appears... contradictory. It's claiming that it's testing a passed result, but then asserting that it's unsuccessful?
I wonder if the input YAML is not set up correctly and is being treated as a failure (e.g. missing properties). Could we try pulling in a passed result like what we document and see if it would turn these values to a successful result?
There was a problem hiding this comment.
Agreed. The author of the test seems not sure which result they wanted to test. Per @jmhooper I used example .yaml files from our docs to split this test into two:
returns a passed resultreturns caution result
| def post_selfie | ||
| raise NotImplementedError, |
There was a problem hiding this comment.
is there a spec that ensures this method is defined? if not, I would just delete it because we still get a NoMethodError when calling it, almost the same as NotImplementedError
🎫 Ticket
LG-7711
🛠 Summary of changes