LG-7810: Zero-pad SC ID numbers if < 8 digits#7226
Merged
Conversation
changelog: Improvements, Identity Verification, Pad SC ID numbers with leading zeros if less than 8 digits.
aduth
reviewed
Oct 26, 2022
don't mutate the original PII Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
solipet
force-pushed
the
dprice-lg-7810-zero-pad-sc-id-numbers
branch
from
163ce08 to
0acd684
Compare
jmhooper
approved these changes
Oct 26, 2022
solipet
force-pushed
the
dprice-lg-7810-zero-pad-sc-id-numbers
branch
2 times, most recently
from
f2015de to
d12217a
Compare
solipet
force-pushed
the
dprice-lg-7810-zero-pad-sc-id-numbers
branch
from
d12217a to
44a16ff
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Improvements, Identity Verification, Pad SC ID numbers with leading zeros if less than 8 digits.
🎫 Ticket
LG-7810: Leading zero for South Carolina AAMVA users
🛠 Summary of changes
We discovered that AAMVA was failing to proof South Carolina users if their state ID number was less than 8 digits. This PR pads the ID number with leading zeros if necessary.
📜 Testing Plan
Aside from the include spec, we will simply have to monitor submission upon deployment.