Skip to content

Add sassc error message troubleshooting and make lint#7227

Merged
jskinne3 merged 2 commits intomainfrom
jskinne3-add-sassc-and-lint-to-README
Oct 26, 2022
Merged

Add sassc error message troubleshooting and make lint#7227
jskinne3 merged 2 commits intomainfrom
jskinne3-add-sassc-and-lint-to-README

Conversation

@jskinne3
Copy link
Contributor

🎫 Ticket

While working on LG-7711 discovered missing README items

🛠 Summary of changes

Updated README with:

  1. advice for cannot load such file -- sassc error
  2. how to lint code

📜 Testing Plan

Test the additions to the README:

  • If you have sassc errors, execute make run and then cancel it
  • Run make lint to confirm it works

🚀 Notes for Deployment

N/A

@aduth
Copy link
Contributor

aduth commented Oct 26, 2022

I'd be more concerned that sassc is running at all under any circumstance, since Sass compilation happens by an entirely separate process 🤔 Maybe we need to be configuring Rails to not try to process any Sass files?

@jskinne3 jskinne3 requested a review from a team October 26, 2022 19:55
@jskinne3
Copy link
Contributor Author

I'd be more concerned that sassc is running at all under any circumstance, since Sass compilation happens by an entirely separate process 🤔 Maybe we need to be configuring Rails to not try to process any Sass files?

I'll refer this observation to @jmhooper from whom I got the technique I added to the README

@jskinne3 jskinne3 merged commit 6fc1fd3 into main Oct 26, 2022
@jskinne3 jskinne3 deleted the jskinne3-add-sassc-and-lint-to-README branch October 26, 2022 20:55
@aduth aduth mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants