Skip to content

Remove the last few selfie references in the error generator#7241

Merged
jmhooper merged 3 commits intomainfrom
jmhooper-further-error-generator-cleanup
Oct 28, 2022
Merged

Remove the last few selfie references in the error generator#7241
jmhooper merged 3 commits intomainfrom
jmhooper-further-error-generator-cleanup

Conversation

@jmhooper
Copy link
Contributor

We are removing IAL2 strict and selfie match functionality. This commit cleans up the last references to the selfie match portions of the ErrorGenerator.

The ErrorGenerator produces a takes the reponse and ultimately generates an errors hash data structure which can be used to render errors to the user on specific images (e.g. the front, back, selfie, or entire ID). This commit removes the code that covered special cases for selfie failures.

We are removing IAL2 strict and selfie match functionality. This commit cleans up the last references to the selfie match portions of the `ErrorGenerator`.

The `ErrorGenerator` produces a takes the reponse and ultimately generates an errors hash data structure which can be used to render errors to the user on specific images (e.g. the front, back, selfie, or entire ID). This commit removes the code that covered special cases for selfie failures.

[skip changelog]
@jmhooper jmhooper changed the title Remove that last few selfie references in the error generator Remove the last few selfie references in the error generator Oct 27, 2022
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmhooper jmhooper merged commit 03b18ae into main Oct 28, 2022
@jmhooper jmhooper deleted the jmhooper-further-error-generator-cleanup branch October 28, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants