Skip to content

LG-7914 IPP PO Search: ArcGIS API Auth Strategy change#7223

Merged
allthesignals merged 2 commits intomainfrom
wmg/7914-auth-strategy
Oct 26, 2022
Merged

LG-7914 IPP PO Search: ArcGIS API Auth Strategy change#7223
allthesignals merged 2 commits intomainfrom
wmg/7914-auth-strategy

Conversation

@allthesignals
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket.

🛠 Summary of changes

Previously, I was using a long-lived API Token I generated from the GSA-supplied ESRI-hosted ArcGIS API (developer dashboard UI).

Now, I am using the OAuth-style authorization strategy from the GSA-hosted GIS Enterprise Platform. Further, I am directing API calls to the GSA-hosted "portal" service.

This includes changes to the particular endpoint pathnames used.

Implements "dynamic_headers," borrowed from Proofer.

Adds new tests for implicit re-auth upon expiration.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Automated test coverage
  • Manual checks

🚀 Notes for Deployment

We will need to update the environment variables for these new credentials.

@allthesignals allthesignals requested review from a team and sheldon-b October 26, 2022 01:52
@allthesignals allthesignals force-pushed the wmg/7914-auth-strategy branch 2 times, most recently from 0f49599 to d21eabb Compare October 26, 2022 02:22
@allthesignals allthesignals force-pushed the wmg/7914-auth-strategy branch from d21eabb to e566915 Compare October 26, 2022 02:25
@allthesignals allthesignals force-pushed the wmg/7914-auth-strategy branch 7 times, most recently from 669a736 to afb5ffc Compare October 26, 2022 17:05
@allthesignals allthesignals force-pushed the wmg/7914-auth-strategy branch 2 times, most recently from ec03a40 to 4aa122b Compare October 26, 2022 19:01
@allthesignals allthesignals force-pushed the wmg/7914-auth-strategy branch from 4aa122b to 9335f3d Compare October 26, 2022 20:35
@allthesignals allthesignals force-pushed the wmg/7914-auth-strategy branch from 9335f3d to 50d66e4 Compare October 26, 2022 20:48
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
@allthesignals allthesignals merged commit 08b0a7c into main Oct 26, 2022
@allthesignals allthesignals deleted the wmg/7914-auth-strategy branch October 26, 2022 22:33
@aduth aduth mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants