Conversation
changelog: Internal, Performance, Improve email send performance by reducing stylesheet size
zachmargolis
approved these changes
Oct 27, 2022
mitchellhenke
approved these changes
Oct 27, 2022
Contributor
|
Looks like the other email change didn't make it into RC 222, so I won't worry about cherry-picking this one on |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
As a follow-on to #7224, adds a missing CSS class
radius-lgcurrently used in email templates.identity-idp/app/views/user_mailer/in_person_ready_to_verify.html.erb
Line 18 in 08b0a7c
It may have been missed in part since
.radiusis a class provided byfoundation-emailsso it may have been assumed the same for.radius-lg, but in-fact this is implemented as a design system utility.