Conversation
jmax-gsa
force-pushed
the
LG-7752-new-irs-content
branch
from
55fb10d to
0ebc6ee
Compare
jmax-gsa
force-pushed
the
LG-7752-new-irs-content
branch
from
0ebc6ee to
8c7b554
Compare
jmax-gsa
force-pushed
the
LG-7752-new-irs-content
branch
from
f340f76 to
221aeff
Compare
jmhooper
approved these changes
Oct 25, 2022
aduth
reviewed
Oct 25, 2022
jmhooper
reviewed
Oct 27, 2022
Much better CSS Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
aduth
reviewed
Oct 27, 2022
| color: color('white'); | ||
|
|
||
| &::before { | ||
| background-image: url('alert/info-white.svg'); |
Contributor
There was a problem hiding this comment.
You'll need to add this image file from my previous comment at #7216 (comment)
Contributor
Author
There was a problem hiding this comment.
Yes, I know. But adding these changes was a push button; actually creating the file takes a finite amount of time.
Contributor
There was a problem hiding this comment.
Did you want the icon to be white?
aduth
reviewed
Oct 27, 2022
jmhooper
pushed a commit
that referenced
this pull request
Oct 27, 2022
Added info box for IRS re-proofing. Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Comment on lines
+11
to
+18
| <% if @current_user&.decorate&.reproof_for_irs?(service_provider: @current_sp) %> | ||
| <%= render AlertComponent.new( | ||
| type: :info, | ||
| message: t('doc_auth.info.irs_reproofing_explanation'), | ||
| class: ['margin-bottom-2', 'usa-alert--info-important'], | ||
| ) | ||
| %> | ||
| <% end %> |
Contributor
There was a problem hiding this comment.
Next time, I would indent this
Suggested change
| <% if @current_user&.decorate&.reproof_for_irs?(service_provider: @current_sp) %> | |
| <%= render AlertComponent.new( | |
| type: :info, | |
| message: t('doc_auth.info.irs_reproofing_explanation'), | |
| class: ['margin-bottom-2', 'usa-alert--info-important'], | |
| ) | |
| %> | |
| <% end %> | |
| <% if @current_user&.decorate&.reproof_for_irs?(service_provider: @current_sp) %> | |
| <%= render AlertComponent.new( | |
| type: :info, | |
| message: t('doc_auth.info.irs_reproofing_explanation'), | |
| class: ['margin-bottom-2', 'usa-alert--info-important'], | |
| ) | |
| %> | |
| <% end %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket.
🛠 Summary of changes
Added explanitory message when the IRS forces a use to re-proof.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
Before:
After:
🚀 Notes for Deployment
Include any special instructions for deployment.