LG-7718 ArcgisApi::Geocoder Cache API token#7238
Merged
allthesignals merged 10 commits intomainfrom Oct 27, 2022
Merged
Conversation
aduth
reviewed
Oct 27, 2022
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
approved these changes
Oct 27, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Agree with Zach's comment, but otherwise LGTM. My comments are pretty minor / optional, so not anything to block if you have reservations about them.
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
allthesignals
commented
Oct 27, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket.
🛠 Summary of changes
Cache ArcgisApi::Geocoder token using Rails.cache so that tokens may be shared across multiple application instances.
Previously, tokens were stored as class variables so they could be shared across class instances.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
🚀 Notes for Deployment
Add credentials to deploy environments