Merge master into kysedate fork#3
Merged
kysedate merged 88 commits intokysedate:masterfrom Mar 29, 2018
Merged
Conversation
* Removing autobind usage as a test in Button. * Adding change.
* Add LinkBase to exports. * Added change file.
The aria-label was set on the nested <ul> element. Per [WAI guidelines][1] the aria-label should be set on the element having the "navigation" role. This is especially important when multiple navigation landmarks exist in the DOM tree. [1]: https://www.w3.org/WAI/GL/wiki/Using_ARIA_landmarks_to_identify_regions_of_a_page
* Adding high contrast to getFocusStyle * Removing extra border for split button in high contrast * CommandBar button has its own focus style in hc mode * Added change files * Switching button high contrast fix from styling to button * From let to const * Button style refactor * Using color param for focus * Passing high contrast style obj to getFocusStyle * highContrastStyle * Updated snapshots * Semicolons * Update experiements snapshots * Removed unused imports
* Switched 0078d7 to 0078d4 * Updated snapshots * Added change files
* Fix issue 3608: DetailsList horizontal scroll * DetailsList: scrollbars show up unnecessarily on IE11 * add change file
* fix imports * changefile
* Fix ContextualMenuItem Icon High Contrast colors. * Added change file. * Turned " into '.
#4261) * transitioning title attribute to render as tooltip, and adding readonly state for command bar items * more changes * small changes * fixing merge issues * fixed merge issue * pr feedback * added white space * fixed tests and ts lint errors
* Added public openMenu method and cleaned up open/close functions * Change file * Update BaseButton.tsx
…er wants the input element to lose the focus on arrow key (#4290) * Test * Scenario determines if to loose focus or not * update * PR comment * Add returns * Add test * update test * Update change log * Increase bundle maxsize
* Javascript styling for Spinner * rush change * Removing Spinner.scss * Examples no longer use inline-block, native props are forwarded to root
* Replace refs with createRef * A few more createRef * More createRef * Marquee createRef * Almost done! :) * Almost done! * Add npm change * Use componentRef for setting a ref to a FocusZone * One more ref -> componentRef
* Adds basic skeleton of Shimmer Component to office-ui-fabric-react. * Register the Shimmer component in the library. * Adds basic skeleton of Shimmer Component to office-ui-fabric-react. * Register the Shimmer component in the library. * Starting to implement mergeStyles to create examples of component. * Introduces the svg plus styles a little. * Adds css background-size to mergeStyles.api and adds basic shimmer animation. * Splits Shimmer into the main host and shapes inside. * Adds rectangle shape to shimmer. * Changes the logic to exposure of the shapes of shimmer only internaly. * Adds ability to to add different elements to the shimmer line. * Refactors the naming of some interfaces and forces a more strict type check. * Moves the function bo get the borderAlignStyles to Shimmer.base.tsx * Adds wrapper around the shimmer to position it absolute for fadeOut animation. * Creates two basic examples for shimmer page. * Sets a list with hovercards to demonstrate Shimmer Application. * Small changes in the logic of calculating the borders. * Change log plus remove mergeStyleAPI change for a different PR * Cleans TSLint errors. * Cleans unused import. * Moves the shimmer component to experiments folder. * Adjusts all imports to make it run in experiments. * Adds Change log plus cleans the code a little. * Corrects all typescript linting errors. * Fixes another tslint error * Removes unnecessary circle state. * Small fix for importing. * Sets up a scrolling list simulating data loading when scrolling using Shimmer while waiting. * Introduces more props to Shimmer. * Enables back simulation of asynchronus loading of data for example page. * Adds shimmer to DetailsList advanced example. * Fixes some names and styles. * Moved ShimmerRectangle Interfaces in a different folder. * Moves ShimmerCircle Interfaces to a different file. * Reevaluates some of the language for the documentation. * Changes the ShimmerRectangle name to ShimmerLine for better semantics and avoid collision with an already existing IRectangle interface. * Extracts a value to a constant. * Changes the logic of calculating the maxHeight and extracting height defaults for circle and line into one source. * Changes the name for isDetailsList prop. * Renames Shimmer prop from isListMissingItem to isBaseStyle to give it more general sense. * Cleans up the code a little. * Styles left margin only for the Shimmer Application Example. * Change log commit.
* Changing toggle styles to use flex box * Adding change request file * Updating toggle snapshot * Fixing style for disabled and checked toggle * Adding comment * Removing comment
…er the SearchBox has focus or not (#4316) * Add hasFocus public api to Search box * Add change log * Minor * Fix comment * Remove the patch change log
…rt OnClick behavior (#4314) Reordered the logic so an anchor tag can have an onclick function if desired
* Updated toolkit links * Added change file
* Fixing a bug introduced by the DetailsHaeder. * Fix for detailsheader resizing. * Adding change files. * Fixing build error. * Removing unnecessary null. * Fixing import?
* Removing empty callout when tooltip content is empty * adding change file
…on activity card (#4299) * Add DocumentCardLogo * add changes file * add changes file * update * update on title to support secondary title used as text preview * update * update * remove focusZone fix that is not relevant to this change * removed unintentional changed files * update * change file * update
* Add missing quaternary and alt colors on doc page * + change file
* Deprecate SearchBox defaultValue prop. * npm run change output
…xceptions in IE) (#4294) * [BasePicker] suggestions should not be shown when input does not exist * added change file * Update master_2018-03-16-09-03.json
…liminate confusing behaviors. (#4366) * Add multiSelect for ComboBox * Unbreak a unit test * rush change * bug fixes * Merge from upstream and resolve local build issues * Fix merge styles * Fix pending background * Unbreak unit test cases * Fix the merge * Add controled multi-select in the example page to make sure onChanged cb works * Remove trailing white spaces * Fix bug: enter key will not trigger onChanged * Dummy change to trigger another build * refactor * Fix some minor bugs * Update some comments for ComboBox * Minor bug fixes to the example page * rush change * Delete the old rush change file * Remove a trailing space * Remove a redundant property from the ComboBox example * rush chagne * Remove old rush change file
* Break on warnings. * Shrinkwrap update.
* create new suggestions, suggestionsControl, and suggestionsStore in experiments * add change files * fix picker tests and separate scss file into two files * Update BaseFloatingPicker.tsx * remove autobind reference from bad merge * address PR comments * address PR comments, fix selection for shouldSelectFirstItem
* Updating checkbox select. * addin change. * Fix snapshot.
…tment (#4369) * made spin button and base button menu option un-focusable * added spin button test * added split button contextual menu change * got rid of un-needed code * added change files * added abillitiy to not focus on primary button for split button, but only on the container * enter on focus on split button trigger primary action * added split button style for disabled * prevent opening submenu if item is disabled * tighten restrictions on opening split buttons to open with alt + down * refactored button name and fixed test * updated bundle size * changed on menu item click to bw able to take in a keyboard event * updated package json * fixed weird tabbing * changed way we structured the focus * added stop propagation * changed split button container key down to work with other buttons now * update bundle size * added correct split button container styles * removed unnecessary attribute * fixed focusing on menu button when primary button is disabled * added change to focus * added aria hidden * fixed span location and moved TODO * added support to focus on whole container in split button for contextual menus * added comment * fixed styling issues with buttons * fixed style problems for contextual split button where content is centered * reverted change * added appropriate change file * Update contextualMenuAlignSplitButton_2018-03-27-18-13.json
#4302) * Add markdown to jsx related packages and update shrinkwrap * Copy template components to example app base and correct imports. * Create example md files * Add Markdown typings * Remove commented code * Test using md files in Activity Item Page * Simplify raw-loader md imports * npm run change output * Expand md import to full path
* Update SplitButton submenu in ContextualMenu to base itself of the splitButtonContainer * rush change * used ref to pass in container instead of parent element for more defenseive code * changed class to use correct refs * added example and refactored focus
* Adding option for calculating initials for phone numbers * Added change description * Name change and cleanup * Update initials-for-phonenumbers_2018-03-27-14-10.json * Update initials-for-phonenumbers_2018-03-27-14-10.json
* Add markdown to jsx related packages and update shrinkwrap * Copy template components to example app base and correct imports. * Create example md files * Add Markdown typings * Remove commented code * Test using md files in Activity Item Page * Simplify raw-loader md imports * npm run change output * Expand md import to full path * Move markdown and syntax packages to dependencies. * Move md files to docs folder.
…#4392) * Remove root imports of office-ui-fabric-react * Update change output
…cted (#4393) * oops * changefile * dry * max line length error
…Zone (#4400) * Add a prop so that OverflowSets do not have to contain FocusZones * pull the common aspects into variables so they can be reused * simplify OverflowSet even more (use Tag to remove duplication) * Revert back and remove the key since it's no longer needed * rush change * Make sure the focusZoneProps are still getting passed down * The divProperties only need to be used when doNotContainWithinFocusZone is true * Remove unneeded import
…hite (#4395) * DetailsList: link color too close to selected background in high-contrast-white * add change file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
merging master