Color: Changing themePrimary / Communication Blue #4297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynamemi
requested review from
Jahnp,
betrue-final-final,
mikewheaton and
phkuo
Member
|
Wow--I didn't realize how pervasive this specific HEX value was in this codebase. Very comprehensive PR--thank you! Looks great. |
Jahnp
approved these changes
Mar 16, 2018
phkuo
approved these changes
Mar 16, 2018
Member
betrue-final-final
left a comment
betrue-final-final
left a comment
There was a problem hiding this comment.
My hero! #Lynamemirocksmyworld
Member
|
There seems to be some places with hardcoded hex values that need to be changed in another PR. |
Member
|
@betrue-final-final did you look at the diff? @lynamemi changed a ton of hard-coded values that showed up in specs, tests, and JSON files. Were there others in addition to what was changed here? |
Member
|
Just what I saw here. I was surprised. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Our accessibility tool, Keros, was updated and themePrimary (aka Communication Blue) started failing accessibility tests due to the extra decimal (4.495:1). In response, the Microsoft corporate color palette medium blue a.k.a. Communication Blue has been updated from 0078D7 to 0078D4 to meet accessibility requirements.
Focus areas to test
(optional)