BaseButton: removing autobind usage#4279
Merged
dzearing merged 2 commits intomicrosoft:masterfrom Mar 16, 2018
dzearing:button-autobind
Merged
BaseButton: removing autobind usage#4279dzearing merged 2 commits intomicrosoft:masterfrom dzearing:button-autobind
dzearing merged 2 commits intomicrosoft:masterfrom
dzearing:button-autobind
Conversation
Member
Author
|
@christiango @cschleiden @antonlabunets I think we will want to do this in bulk and get rid of autobind usage. it is easier, smaller, requires no import, and has no probability of failing because of a bad tslib __decorate update. You can see that just updating this one file removed almost 100 bytes off the gzip size. |
christiango
approved these changes
Mar 15, 2018
Member
|
I like this! :D Can help to do the same thing in other components if thats helpful. |
Member
Author
|
@Markionium yes please! That would be massively helpful. |
Contributor
|
@dzearing I'm still a fan of autobind ;) But sure, I'm fine with the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to remove
autobindusage in BaseButton to understand:autobindand have code to do this.Also, in general, I believe we may want to get away from decorators, so I'm looking at what that might look like here.