DetailsList: scrollbars show up unnecessarily on IE11#4291
Merged
aditima merged 6 commits intomicrosoft:masterfrom Mar 16, 2018
Merged
DetailsList: scrollbars show up unnecessarily on IE11#4291aditima merged 6 commits intomicrosoft:masterfrom
aditima merged 6 commits intomicrosoft:masterfrom
Conversation
…c-react into aditima/ie11-detailslist-scroll
dzearing
approved these changes
Mar 16, 2018
dzearing
reviewed
Mar 16, 2018
|
|
||
| .focusZone { | ||
| display: inline-block; | ||
| vertical-align: top; |
Member
There was a problem hiding this comment.
this could have potential side effects on some browsers. I think it could be ok, @ThomasMichon any concerns?
Contributor
Author
There was a problem hiding this comment.
Spoke to David on phone. This is certainly a browser bug, the heights of the content and the container are exactly same, but IE doesn't line them up correctly unless I get rid of this vertical align. I actually feel a little less bad about this because it's only changing the DetailsList styles. Tested on Chrome and works for the basic cases and the demo page.
I'll go ahead and merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Fixed css to remove vertical-align style
Focus areas to test