Skip to content

Add LinkBase to exports.#4256

Merged
dzearing merged 2 commits intomicrosoft:masterfrom
dmarcey:users/demarcey/linkBaseExport
Mar 16, 2018
Merged

Add LinkBase to exports.#4256
dzearing merged 2 commits intomicrosoft:masterfrom
dmarcey:users/demarcey/linkBaseExport

Conversation

@dmarcey
Copy link
Copy Markdown
Collaborator

@dmarcey dmarcey commented Mar 13, 2018

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

Export LinkBase from index.ts, so that consumers don't have to have imports like:

import { LinkBase } from "OfficeFabric/components/Link/Link.base";

Focus areas to test

(optional)

@dmarcey dmarcey requested a review from dzearing March 13, 2018 20:01
Copy link
Copy Markdown
Member

@dzearing dzearing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick request, add change file so that it gets published.

@dmarcey
Copy link
Copy Markdown
Collaborator Author

dmarcey commented Mar 13, 2018

Sorry, I created, but didn't push the change file.

@dzearing dzearing merged commit 8fcd8e3 into microsoft:master Mar 16, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants