ShimmerComponent new props#4254
Merged
dzearing merged 51 commits intomicrosoft:masterfrom Mar 20, 2018
Merged
Conversation
added 30 commits
February 26, 2018 18:34
…1/office-ui-fabric-react into v-vibr/ShimmerComponent
… Shimmer while waiting.
added 21 commits
March 7, 2018 19:03
… and avoid collision with an already existing IRectangle interface.
…defaults for circle and line into one source.
… more general sense.
dzearing
reviewed
Mar 13, 2018
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "changes": [ | |||
Member
There was a problem hiding this comment.
@Vitalius1 are you working with someone on this? It would be great to have pair ownership to ensure we have someone who can more deeply provide feedback and shared fixing.
Contributor
Author
There was a problem hiding this comment.
Yes I am. Mainly I get feedback from @atneik .
dzearing
reviewed
Mar 20, 2018
|
|
||
| export const enum ShimmerElementType { | ||
| RECTANGLE = 'line', | ||
| LINE = 'line', |
Member
There was a problem hiding this comment.
These enum values should just be camelCased.
Contributor
Author
There was a problem hiding this comment.
Got it. Will definitely change them in my next PR. Thanks!
Member
|
@Vitalius1 I left a comment about enum naming, but will still merge this. Maybe you could fix in your next PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Addressing the feedback from previous PR.
Adds new props and changes the name of other ones.
Changes in logic to prepare the component being used width DetailsList
Focus areas to test
Naming of the props if clear and general enough.