Added public openMenu method and cleaned up open/close functions#4241
Merged
micahgodbolt merged 4 commits intomicrosoft:masterfrom Mar 19, 2018
micahgodbolt:button-openMenu
Merged
Added public openMenu method and cleaned up open/close functions#4241micahgodbolt merged 4 commits intomicrosoft:masterfrom micahgodbolt:button-openMenu
micahgodbolt merged 4 commits intomicrosoft:masterfrom
micahgodbolt:button-openMenu
Conversation
sayali26
approved these changes
Mar 19, 2018
martellaj
approved these changes
Mar 19, 2018
Member
martellaj
left a comment
martellaj
left a comment
There was a problem hiding this comment.
This is awesome. Can we get this reviewed by someone on the Fabric team and get this merged? We'd love to use this prop in OWA. Thank, Micah!
Member
Author
|
yeah, I just need to clean up the conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.