Merged
Conversation
Markionium
requested review from
Jahnp,
aditima,
atneik,
cschleiden,
johannao76,
joschect,
lorejoh12,
micahgodbolt,
mikewheaton,
phkuo and
yiminwu
as code owners
Member
|
Woohoo! |
martellaj
reviewed
Mar 21, 2018
| } | ||
|
|
||
| @autobind | ||
| protected onInputChange(value: string) { |
Member
There was a problem hiding this comment.
@Markionium @dzearing Please avoid changing how public/protected members are defined in the future. This is technically breaking as anyone who overrides it (like I do) won't be able to compile when taking this version.
Member
|
@dzearing @Markionium Why are we preferring the arrow function instead of
I could argue that, this is a disaster deprecation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Replace @autoBind with arrow function properties
See #4279
Focus areas to test
(optional)