Nav component sets aria-label on <nav> element#4266
Merged
dzearing merged 1 commit intomicrosoft:masterfrom Mar 16, 2018
Merged
Nav component sets aria-label on <nav> element#4266dzearing merged 1 commit intomicrosoft:masterfrom
dzearing merged 1 commit intomicrosoft:masterfrom
Conversation
The aria-label was set on the nested <ul> element. Per [WAI guidelines][1] the aria-label should be set on the element having the "navigation" role. This is especially important when multiple navigation landmarks exist in the DOM tree. [1]: https://www.w3.org/WAI/GL/wiki/Using_ARIA_landmarks_to_identify_regions_of_a_page
gingi
force-pushed
the
nav-element-aria-label
branch
from
bcbb371 to
7ad348c
Compare
dzearing
approved these changes
Mar 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
The aria-label was set on the nested
<ul>element. Per WAI guidelines thearia-labelshould be set on the element having the "navigation" role (<nav>). This is especially important when multiple navigation landmarks exist in the DOM tree (which need to be distinguished by theiraria-label).Includes unit test to isolate expected behavior.