[5.4] Upmerge changes from 5.3-dev 2025-02-28 by richard67 · Pull Request #45035 · joomla/joomla-cms

richard67 · 2025-02-28T10:53:33Z

Pull Request for Issue # .

Summary of Changes

This pull request (PR) merges the changes from 5.3-dev up into 5.4-dev which have been made since the last upmerge PR #45009 .

Important hint for maintainers

This PR has to be merged with a merge commit, not a squash commit.

Testing Instructions

Review. Check the commits of this PR and those in the 5.3-dev branch.

Actual result BEFORE applying this Pull Request

5.4-dev branch is not up to date with 5.3-dev.

Expected result AFTER applying this Pull Request

5.4-dev branch is up to date with 5.3-dev.

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

…#44864)

…of type string is deprecated (joomla#44876)

…oomla#44488)

* Combine multiple unset call into one call * Remove unnecessary blank lines * Move comments to right position * Update administrator/components/com_templates/src/Model/TemplateModel.php Co-authored-by: Harald Leithner <leithner@itronic.at> * Update libraries/src/User/User.php Co-authored-by: Harald Leithner <leithner@itronic.at>

…44982) * Change isset($var) && multiple times to one call * Remove redundant checks * Update components/com_users/src/View/Profile/HtmlView.php --------- Co-authored-by: Quy Ton <quy@nomonkeybiz.com> Co-authored-by: Harald Leithner <leithner@itronic.at>

Co-authored-by: Harald Leithner <leithner@itronic.at>

* Change list() to array destruct for libraries code

…oomla#44970) * Change list() to array destruct for modules and plugins code --------- Co-authored-by: Quy Ton <quy@nomonkeybiz.com>

…oomla#44969)

…omla#44967)

* Add deprecation message to content modules --------- Co-authored-by: Quy <quy@nomonkeybiz.com>

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

…joomla#44896)

…la#44972)

The `CYPRESS_CACHE_FOLDER` environment variable must be set within the `sudo` command.

* [Cypress] PHP Backend Notice com_media/Files.cy.js Fixing all Joomla backend PHP notices from Cypress test file `api/com_media/Files.cy.js` and doing some refactoring. Fixed PHP notices are: ``` [Sat Feb 22 18:28:44.019593 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice: exif_imagetype(): Error reading from /var/www/html/files/test-image-1.jpg! in /var/www/html/libraries/src/Helper/MediaHelper.php on line 93 [Sat Feb 22 18:28:44.022074 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice: getimagesize(): Error reading from /var/www/html/files/test-image-1.jpg! in /var/www/html/libraries/src/Image/Image.php on line 177 [Sat Feb 22 18:28:44.258619 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice: exif_imagetype(): Error reading from /var/www/html/files/test-dir/test-image-1-subfolder.jpg! in /var/www/html/libraries/src/Helper/MediaHelper.php on line 93 [Sat Feb 22 18:28:44.259092 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice: getimagesize(): Error reading from /var/www/html/files/test-dir/test-image-1-subfolder.jpg! in /var/www/html/libraries/src/Image/Image.php on line 177 [Sat Feb 22 18:28:47.177357 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice: exif_imagetype(): Error reading from /var/www/html/files/test-dir/todelete.jpg! in /var/www/html/libraries/src/Helper/MediaHelper.php on line 93 [Sat Feb 22 18:28:47.178099 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice: getimagesize(): Error reading from /var/www/html/files/test-dir/todelete.jpg! in /var/www/html/libraries/src/Image/Image.php on line 177 [Sat Feb 22 18:28:47.564807 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice: exif_imagetype(): Error reading from /var/www/html/images/test-dir/todelete.jpg! in /var/www/html/libraries/src/Helper/MediaHelper.php on line 93 [Sat Feb 22 18:28:47.565288 2025] [php:notice] [pid 31:tid 31] [client 10.0.0.1:64714] PHP Notice: getimagesize(): Error reading from /var/www/html/images/test-dir/todelete.jpg! in /var/www/html/libraries/src/Image/Image.php on line 177 ``` All 8 x PHP notices are fixed. Instead of using 1-Byte files real images are used from Cypress fixtures. Please consider there are still 4 x PHP warning to be fixed (I assume they need to be fixed in PHP API backend code) from `api/com_media/Files.cy.js` and more warnings and notices in the overall Joomla System Tests. Some refactoring: * Deleted 3 images in `tests/System/data/com_media`, 2 are not used and Cypress default is to use `fixtures` folder * The image file names are counted through and the images show name and path in different colors. * Second `test-dir` was named `test-dir2` to distinguish clearly. * `afterEach()` is reduced to `after()`, as it is only a clean-up and not needed to execute the tests. * The last 4 tests can use the prepared files too, as with `beforeEach` the files are restored before each test. * Corrected Image Description to test-dir2 Used command: ``` convert -size 100x100 -gravity center -pointsize 11 xc:lightgreen -fill red -annotate +0+0 'Joomla\nSystem Tests\n\nimages/test-dir2\ntest-image-3.jpg' tests/System/fixtures/com_media/test-image-3.jpg ``` * Fix for Windows Path and Read-Only Overwrites - Creating relative fixtures folder path now also works on Windows with backslashes as separators and a drive letter - All overwrite files are now created with explicit read-write 0o666, as the default 0o444 creates read-only files, leading to PHP Warnings `Failed to open` --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> Co-authored-by: Robert Deutz <rdeutz@googlemail.com>

) * Remove unsed variable * fix as reuested * Add a comment --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>

…2025-02-28

…2-28

…2025-02-28

SniperSister and others added 30 commits February 20, 2025 17:01

[5.2][system tests] Do not delete tuf metadata (joomla#44866)

741e775

Set column alias for BannerTable, fix warning on Save As Copy (joomla…

ec31a42

…#44864)

[5.2] Translation Update (joomla#44919)

f716005

[5.2] PHP Deprecated: trim(): Passing null to parameter #1 ($string) …

64ac8c8

…of type string is deprecated (joomla#44876)

Add border last element media breadcrumbs (joomla#44995)

4b5ff87

[5.2] Disable compat plugin for system tests (joomla#44997)

1a5ea16

[cypress] Update Menu.cy.js (joomla#45005)

97754e1

Update contact.xml (joomla#44988)

150f520

Redesign carousel implementation to reflect documentation - bug fix (j…

eb1fed9

…oomla#44488)

[5.3] better use str_starts_with (joomla#44998)

ced9cfe

Simplify code using no_unneeded_control_parentheses rule (joomla#44981)

26d8886

Co-authored-by: Harald Leithner <leithner@itronic.at>

Improve api app code using rector rules (joomla#44975)

3f2caca

Co-authored-by: Harald Leithner <leithner@itronic.at>

[5.3] Change list() to array destruct for libraries code (joomla#44973)

b7fee10

* Change list() to array destruct for libraries code

[5.3] Change list() to array destruct for modules and plugins code (j…

1bd1dd6

…oomla#44970) * Change list() to array destruct for modules and plugins code --------- Co-authored-by: Quy Ton <quy@nomonkeybiz.com>

Changes unneeded null check to ?? operator for modules and plugins (j…

867945a

…oomla#44969)

Remove unused variable in try catch block for modules and plugins (jo…

aae2d2b

…omla#44967)

Add frontediting setting (joomla#44978)

fb9aa8e

Fix MailsHelper::loadTranslationFiles (joomla#44952)

f6a24db

Fix dispatcher ACl checks: ignore any non-display tasks (joomla#44951)

45b59b6

[5.2] Add legacy message to content modules (joomla#44366)

064c8f6

* Add deprecation message to content modules --------- Co-authored-by: Quy <quy@nomonkeybiz.com>

[5.3] Handle fields event in EmailCloak plugin (joomla#44923)

dcbaacd

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

[5.3] Category View: Fix meta tag for author (joomla#44903)

3be1e6c

Composer update php-debugbar to 1.23.6 (joomla#44901)

87220a4

[5.3] Make mailtemplate information available in mail template layout (…

c3eeb32

…joomla#44896)

[5.3] Replace calls to dirname(__FILE) with __DIR__ (joomla#44882)

576f005

[5.3] Remove unnecessary array internal pointer resets (joomla#44881)

a9c5a1b

Use null coalescing assignment operator for modules and plugins (joom…

c727588

…la#44972)

Fix Field Group permission check (joomla#44956)

1d7650b

chmst and others added 7 commits February 28, 2025 00:39

[5.3] Fields batch copy category (joomla#44943)

4c6bb85

[5.x][docu] Minor sudo fix (joomla#45031)

2e81829

The `CYPRESS_CACHE_FOLDER` environment variable must be set within the `sudo` command.

Merge remote-tracking branch 'upstream/5.2-dev' into 5.3-dev-upmerge-…

457e5f4

…2025-02-28

Merge pull request joomla#45034 from richard67/5.3-dev-upmerge-2025-0…

a971099

…2-28

Merge remote-tracking branch 'upstream/5.3-dev' into 5.4-dev-upmerge-…

f61dca9

…2025-02-28

richard67 requested a review from rdeutz as a code owner February 28, 2025 10:53

joomla-cms-bot added the PR-5.4-dev label Feb 28, 2025

richard67 removed the request for review from rdeutz February 28, 2025 10:54

richard67 merged commit 362ec5e into joomla:5.4-dev Feb 28, 2025
3 checks passed

richard67 deleted the 5.4-dev-upmerge-2025-02-28 branch February 28, 2025 11:28

richard67 added this to the Joomla! 5.4.0 milestone Feb 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[5.4] Upmerge changes from 5.3-dev 2025-02-28#45035

[5.4] Upmerge changes from 5.3-dev 2025-02-28#45035
richard67 merged 37 commits intojoomla:5.4-devfrom
richard67:5.4-dev-upmerge-2025-02-28

richard67 commented Feb 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Uh oh!

Conversation

richard67 commented Feb 28, 2025

Summary of Changes

Important hint for maintainers

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants