Skip to content

[5.3] Remove unused exception variable in catch for modules and plugins#44967

Merged
HLeithner merged 1 commit intojoomla:5.3-devfrom
joomdonation:remove-unused-variable-in-catch-for-modules-plugins
Feb 26, 2025
Merged

[5.3] Remove unused exception variable in catch for modules and plugins#44967
HLeithner merged 1 commit intojoomla:5.3-devfrom
joomdonation:remove-unused-variable-in-catch-for-modules-plugins

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR uses RemoveUnusedVariableInCatchRector rector rule to remove unused exception variable in try catch block in our modules and plugins code. This is done automatically by rector, no manual change included.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@QuyTon
Copy link
Contributor

QuyTon commented Feb 22, 2025

I have tested this item ✅ successfully on 0465ba9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44967.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Feb 22, 2025

I have tested this item ✅ successfully on 0465ba9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44967.

@alikon
Copy link
Contributor

alikon commented Feb 22, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44967.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2025
@HLeithner HLeithner merged commit aae2d2b into joomla:5.3-dev Feb 26, 2025
4 checks passed
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 26, 2025
@QuyTon QuyTon added this to the Joomla! 5.3.0 milestone Feb 26, 2025
@joomdonation joomdonation deleted the remove-unused-variable-in-catch-for-modules-plugins branch February 27, 2025 05:17
janschoenherr pushed a commit to janschoenherr/joomla-cms that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants