[5.3] Combine multiple unset call into one call#44983
Merged
HLeithner merged 6 commits intojoomla:5.3-devfrom Feb 26, 2025
Merged
[5.3] Combine multiple unset call into one call#44983HLeithner merged 6 commits intojoomla:5.3-devfrom
HLeithner merged 6 commits intojoomla:5.3-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on be9ed6d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44983. |
Contributor
|
Please fix extra blank lines. |
Contributor
Author
|
Done. Thanks @QuyTon |
QuyTon
reviewed
Feb 24, 2025
Contributor
|
I have tested this item ✅ successfully on fe5ccf2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44983. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44983. |
HLeithner
requested changes
Feb 24, 2025
administrator/components/com_templates/src/Model/TemplateModel.php
Outdated
Show resolved
Hide resolved
….php Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Harald Leithner <leithner@itronic.at>
janschoenherr
pushed a commit
to janschoenherr/joomla-cms
that referenced
this pull request
Mar 10, 2025
* Combine multiple unset call into one call * Remove unnecessary blank lines * Move comments to right position * Update administrator/components/com_templates/src/Model/TemplateModel.php Co-authored-by: Harald Leithner <leithner@itronic.at> * Update libraries/src/User/User.php Co-authored-by: Harald Leithner <leithner@itronic.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This PR improves code quality of our code base by running PHPCS Fixer for combine_consecutive_unsets rule.
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner code
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed