Skip to content

[5.2][system tests] Do not delete tuf metadata#44866

Merged
pe7er merged 5 commits intojoomla:5.2-devfrom
SniperSister:5x-tuf-system-tests
Feb 20, 2025
Merged

[5.2][system tests] Do not delete tuf metadata#44866
pe7er merged 5 commits intojoomla:5.2-devfrom
SniperSister:5x-tuf-system-tests

Conversation

@SniperSister
Copy link
Contributor

Pull Request for Issue #44859 , alternative approach to #44861

Summary of Changes

Do not delete tuf_metadata in afterEach() cleanupDB

Testing Instructions

  • run specs tests/System/integration/administrator/components/com_joomlaupdate/Update.cy.js
  • check content of tuf_metadata table

Actual result BEFORE applying this Pull Request

table is empty

Expected result AFTER applying this Pull Request

one entry with id=1

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

This comment needs correcting as it is for inserting valid tuf data

* Inserts an invalid tuf metadata set

@SniperSister
Copy link
Contributor Author

done

Co-authored-by: Brian Teeman <brian@teeman.net>
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 475a644


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44866.

1 similar comment
@laoneo
Copy link
Member

laoneo commented Feb 12, 2025

I have tested this item ✅ successfully on 475a644


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44866.

@QuyTon
Copy link
Contributor

QuyTon commented Feb 12, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44866.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 12, 2025
@pe7er pe7er enabled auto-merge (squash) February 20, 2025 15:33
@pe7er pe7er merged commit 741e775 into joomla:5.2-dev Feb 20, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 20, 2025
@pe7er pe7er added this to the Joomla! 5.2.5 milestone Feb 20, 2025
@pe7er
Copy link
Contributor

pe7er commented Feb 20, 2025

Thanks @SniperSister !

@laoneo
Copy link
Member

laoneo commented Feb 21, 2025

Nice, thanks for the help @SniperSister!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants