[5.3] Change list() to array destruct for modules and plugins code#44970
Merged
HLeithner merged 3 commits intojoomla:5.3-devfrom Feb 26, 2025
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 271f863 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44970. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 271f863 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44970. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44970. |
Member
|
thanks |
joomdonation
deleted the
use-list-to-array-destruct-for-modules-plugins
branch
janschoenherr
pushed a commit
to janschoenherr/joomla-cms
that referenced
this pull request
Mar 10, 2025
…oomla#44970) * Change list() to array destruct for modules and plugins code --------- Co-authored-by: Quy Ton <quy@nomonkeybiz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This PR uses ListToArrayDestructRector rector rule to change code form using list function to user more modern array destruct syntax in our modules and plugins code. This is done automatically by rector, no manual change included.
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner code using modern syntax
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed