Skip to content

Comments

[5.3] Category View: Fix meta tag for author#44903

Merged
rdeutz merged 4 commits intojoomla:5.3-devfrom
Hackwar:5.3-category-propertytrait
Feb 27, 2025
Merged

[5.3] Category View: Fix meta tag for author#44903
rdeutz merged 4 commits intojoomla:5.3-devfrom
Hackwar:5.3-category-propertytrait

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Feb 14, 2025

Summary of Changes

The com_content category view has code to add the author of the category as an author meta tag. This code does not work and the meta tag is never set for category views. This PR fixes that.

This is the last occurence of usage of the LegacyPropertyManagementTrait for the CategoryNode class in our core code and would then allow us to delete that trait from that class in 6.0.

Testing Instructions

  1. Create a category and link it in a menu, for example as a blog category view.
  2. Make sure the option Author Meta Tag in global configuration of Joomla is enabled.
  3. Visit the category in the frontend and look at the source code.

Actual result BEFORE applying this Pull Request

No author meta tag.

Expected result AFTER applying this Pull Request

A meta tag similar to the following is displayed: <meta name="author" content="John Doe">

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

shouldnt this go in the schema and not the meta now

@Hackwar
Copy link
Member Author

Hackwar commented Feb 14, 2025

This currently just fixes the existing code. Since the same code is in the article view, I would first fix it like that. Moving this to the schema would be out of scope for this PR and also not what I would want to decide here.

@ghost
Copy link

ghost commented Feb 15, 2025

I have tested this item ✅ successfully on d5dc55d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.

@richard67
Copy link
Member

I have tested this item ✅ successfully on d5dc55d

Tested successfully that the PR does what it says. However, I'm not sure if I really want to have an author tag in a category blog if the author of the articles is different to the author of the category. But as the intention of existing code obviously was to add that meta tag and just the code was wrong, this PR is right, and anything else is out of scope.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 15, 2025
Copy link
Contributor

@bembelimen bembelimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just kill that, it makes, as @richard67 mentioned, no sense to add author to category view

@rdeutz
Copy link
Contributor

rdeutz commented Feb 16, 2025

Agree with @bembelimen we should just remove both lines without a replacement.

@richard67 richard67 removed the RTC This Pull Request is Ready To Commit label Feb 16, 2025
@richard67
Copy link
Member

Back to pending due to requested changes.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 16, 2025
@Hackwar
Copy link
Member Author

Hackwar commented Feb 17, 2025

Ok, done. I removed it entirely.

@Hackwar Hackwar requested a review from bembelimen February 17, 2025 16:37
@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 17, 2025
@QuyTon
Copy link
Contributor

QuyTon commented Feb 20, 2025

I have tested this item ✅ successfully on c18d1ee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.

@ghost
Copy link

ghost commented Feb 20, 2025

I have tested this item ✅ successfully on c18d1ee

Test by using custom update server.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 20, 2025
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 20, 2025
@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 20, 2025
@ZIGUENOTO
Copy link

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903.

@rdeutz rdeutz merged commit 3be1e6c into joomla:5.3-dev Feb 27, 2025
0 of 2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 27, 2025
@rdeutz rdeutz added this to the Joomla! 5.3.0 milestone Feb 28, 2025
janschoenherr pushed a commit to janschoenherr/joomla-cms that referenced this pull request Mar 10, 2025
@Hackwar Hackwar deleted the 5.3-category-propertytrait branch June 10, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants