[5.3] Category View: Fix meta tag for author#44903
Conversation
|
shouldnt this go in the schema and not the meta now |
|
This currently just fixes the existing code. Since the same code is in the article view, I would first fix it like that. Moving this to the schema would be out of scope for this PR and also not what I would want to decide here. |
|
I have tested this item ✅ successfully on d5dc55d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903. |
|
I have tested this item ✅ successfully on d5dc55d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903. |
bembelimen
left a comment
There was a problem hiding this comment.
Can't we just kill that, it makes, as @richard67 mentioned, no sense to add author to category view
|
Agree with @bembelimen we should just remove both lines without a replacement. |
|
Back to pending due to requested changes. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903. |
|
Ok, done. I removed it entirely. |
|
I have tested this item ✅ successfully on c18d1ee This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903. |
|
I have tested this item ✅ successfully on c18d1ee Test by using custom update server. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44903. |
Summary of Changes
The com_content category view has code to add the author of the category as an author meta tag. This code does not work and the meta tag is never set for category views. This PR fixes that.
This is the last occurence of usage of the
LegacyPropertyManagementTraitfor theCategoryNodeclass in our core code and would then allow us to delete that trait from that class in 6.0.Testing Instructions
Author Meta Tagin global configuration of Joomla is enabled.Actual result BEFORE applying this Pull Request
No author meta tag.
Expected result AFTER applying this Pull Request
A meta tag similar to the following is displayed:
<meta name="author" content="John Doe">Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed