Skip to content

[5.2] Composer update maximebf/debugbar to 1.23.6#44901

Merged
rdeutz merged 3 commits intojoomla:5.2-devfrom
richard67:5.2-dev-composer-update-debugbar-1-23-6
Feb 27, 2025
Merged

[5.2] Composer update maximebf/debugbar to 1.23.6#44901
rdeutz merged 3 commits intojoomla:5.2-devfrom
richard67:5.2-dev-composer-update-debugbar-1-23-6

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Feb 14, 2025

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the composed dependency "maximebf/debugbar" from version 1.23.0 to version 1.23.6.

Release notes:

This fixes a few small bugs (which might not be relevant for the CMS core but maybe for 3rd party extensions) and PHP 8.4 deprecations.

There is another PR for 5.3-dev, PR #44902 , which is different to this one here as with version 2 the composer package was renamed.

This will cause merge conflicts for the upmerge from 5.2-dev to 5.3-dev after the 2 PRs will be merged, which have to be resolved by keeping the version from 5.3-dev.

Testing Instructions

Enable "Debug System" in Global Configuration and set "Error Reporting" to "Maximum".

Then use all features of the debug bar.

Change some option of the "System - Debug" plugin, e.g. enable previously disabled options or vice versa, and check the result in the debug bar.

Actual result BEFORE applying this Pull Request

Debug bar works.

Expected result AFTER applying this Pull Request

Debug bar works as before.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Composer update php-debugbar from 1.23.0 to 1.23.6
@alikon
Copy link
Contributor

alikon commented Feb 14, 2025

I have tested this item ✅ successfully on 6362b7b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44901.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 6362b7b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44901.

@richard67
Copy link
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44901.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 15, 2025
@richard67
Copy link
Member Author

@alikon @viocassel Could one of you check if we have an issue with dark mode with this PR applied? Without this PR on a clean 5.2-dev, the debug bar doesn't have any dark mode, so it is still bright when the browser is in dark mode. In 5.3-dev it seems we have a problem with incomplete dark mode of the debugbar, see #44902 (comment) (but that happens also on a clean 5.3-dev without that PR). O worry now this PR here could introduce the same in 5.2-dev, but I don't have the time now to test that due to an urgent meeting.

@alikon
Copy link
Contributor

alikon commented Feb 16, 2025

browser chrome in dark mode without pr
image

browser chrome in dark mode with pr

image

@alikon
Copy link
Contributor

alikon commented Feb 16, 2025

@LadySolveig
Copy link
Contributor

LadySolveig commented Feb 16, 2025

I have tested this item ✅ successfully on 6362b7b

Dark/Light Mode are now displayed correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44901.

@brianteeman
Copy link
Contributor

brianteeman commented Feb 16, 2025

@LadySolveig that is impossible as the dark mode changes are not present in this PR

@richard67
Copy link
Member Author

@brianteeman She wanted to mark the test result in my other PR for 5.3-dev. Meanwhile that's done.

@rdeutz rdeutz enabled auto-merge (squash) February 27, 2025 11:42
@rdeutz rdeutz merged commit 87220a4 into joomla:5.2-dev Feb 27, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 27, 2025
@richard67 richard67 deleted the 5.2-dev-composer-update-debugbar-1-23-6 branch February 27, 2025 13:09
@richard67 richard67 mentioned this pull request Feb 28, 2025
4 tasks
@richard67 richard67 added this to the Joomla! 5.2.5 milestone Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants