[5.3] Replace calls to dirname(__FILE) with __DIR__

[janschoenherr]

Use the __DIR__ constant. It's shorter and doesn't require a function call.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[dgrammatiko]

All these files are the Joomla entry points for the app. I'm not sure if this change will work with the public folder...

[janschoenherr]

I don't think there is a difference. WordPress uses __DIR__ in the index.php.

[joomdonation]

Some changes need to be reverted to make sure fatal error is not thrown when we tried to access in PHP older than 5.3 (Yes, I know it is not going to happen on real life these days, but it is states in the beginning of the file, so we better respect that rule).

[dgrammatiko]

WordPress uses DIR in the index.php

Well, WP doesn't have an option for public folder #40509 but anyways that wasn't really the reason as @joomdonation mentioned it's about compatibility for ancient PHP versions in the app entry points

[HLeithner]

As tuan said, don't change the entry points, we don't win anything here and only loose better looking error messages for really old php versions.

[janschoenherr]

I've reverted the changes in the PHP error messages.

[joomdonation]

I have tested this item ✅ successfully on 3300441

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44882.}

[komalm]

I have tested this item ✅ successfully on 3300441

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44882.}

[QuyTon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44882.}