[5.3] Use null coalescing assignment operator for modules and plugins#44972
Merged
rdeutz merged 2 commits intojoomla:5.3-devfrom Feb 27, 2025
Conversation
Contributor
|
I have tested this item ✅ successfully on 9763cfe This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44972. |
Contributor
Author
|
@viocassel As you are familiar with this kind of PR, could you please review this PR as well? Would love to have this final one of this kind merged. Thanks ! |
Contributor
|
I have tested this item ✅ successfully on 9763cfe This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44972. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44972. |
Contributor
Author
|
Great. Thanks @viocassel ! |
…for_modules_plugins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This PR uses NullCoalescingOperatorRector rector rule to improve our modules and plugins code using
??=operator. This is done automatically by rector, no manual change included.Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner, easier to read code
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed