Skip to content

[5.3] Use null coalescing assignment operator for modules and plugins#44972

Merged
rdeutz merged 2 commits intojoomla:5.3-devfrom
joomdonation:user_null_coalescing_assignment_operator_for_modules_plugins
Feb 27, 2025
Merged

[5.3] Use null coalescing assignment operator for modules and plugins#44972
rdeutz merged 2 commits intojoomla:5.3-devfrom
joomdonation:user_null_coalescing_assignment_operator_for_modules_plugins

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR uses NullCoalescingOperatorRector rector rule to improve our modules and plugins code using ??= operator. This is done automatically by rector, no manual change included.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner, easier to read code

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@QuyTon
Copy link
Contributor

QuyTon commented Feb 22, 2025

I have tested this item ✅ successfully on 9763cfe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44972.

@joomdonation
Copy link
Contributor Author

@viocassel As you are familiar with this kind of PR, could you please review this PR as well? Would love to have this final one of this kind merged. Thanks !

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 9763cfe

👌 Yes, of course. Somehow I missed testing this PR...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44972.

@QuyTon
Copy link
Contributor

QuyTon commented Feb 27, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44972.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 27, 2025
@joomdonation
Copy link
Contributor Author

Great. Thanks @viocassel !

@rdeutz rdeutz merged commit c727588 into joomla:5.3-dev Feb 27, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 27, 2025
@joomdonation joomdonation deleted the user_null_coalescing_assignment_operator_for_modules_plugins branch February 28, 2025 00:53
@rdeutz rdeutz added this to the Joomla! 5.3.0 milestone Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants