Redesign carousel implementation to reflect documentation - bug fix

[iteidrm]

Summary of Changes

This pull request fixes a bug in the Bootstrap Caraousel implementation of Joomla! (PHP and ES/JS) that causes valid parameters to be removed from the JavaScript options object that is fed to the Carousel instance. It replaces #38930.

Testing Instructions

I (still) do not know if the Patch Tester extension will do the JavaScript re-build / pre-processing for you, and hope you know best what to do in this regard. In any case, I've attached not only a demo / test module but also the changed files.

• Activate the debug mode in the global configuration to better be able to inspect the generated JavaScript option object in the source code (Browser: Ctrl + U).
• Install, activate and publish the demo module provided with the pull request on a module position of your choice (e.g. Cassiopeia: main-top). Make sure to set the Menu / Module Assignent to "On all pages".
• Open / refresh the page and change some params in the module manager (e.g. keyboard | wrap to false).

Actual result BEFORE applying this Pull Request

All options set to false are filtered out, causing the carousel to fall back to its default values (not sliding).

Expected result AFTER applying this Pull Request

Params that can have a false value are recognised and the carousel works as expected.

Link to documentations

• Documentation link for docs.joomla.org: https://docs.joomla.org/J4.x:Using_Bootstrap_Components_in_Joomla_4#Carousel (slide vs. ride)

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

@Quy Please let me know if I have missed anything. Also, the problem with filtered parameters may not only exist in the carousel implementation, but in any other Bootstrap component where "false" is a valid option and array_filter is used in the corresponding helper method.

mod_bs_carousel.zip
patched_files.zip

[ghost]

I (still) do not know if the Patch Tester extension will do the JavaScript re-build / pre-processing for you, and hope you know best what to do in this regard.

The Pull Request have the Label NPM Resource Changed; hovering the Label give This Pull Request can't be tested by Patchtester.

[iteidrm]

The Pull Request have the Label NPM Resource Changed; hovering the Label give This Pull Request can't be tested by Patchtester.

@fgsw thanks for the clarification.

[richard67]

People can download a package created by Drone, or update to that package using a custom URL. Both can be found by following the "Details" link at the right side of the "Download" step in the CI checks at the bottom of this PR.

[Quy]

I have tested this item ✅ successfully on d6fe622

Thank you so much for the updated PR/demo file! Great observation with array_filter. Hope to see more contributions from you.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44488.}

[ceford]

I have tested this item ✅ successfully on bfca268

I can fix the documentation if you like.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44488.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44488.}

[richard67]

I can fix the documentation if you like.

@ceford That would be great. But you should wait until this PR is merged and released.

[ceford]

I jumped the gun and updated the documentation!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44488.}