Skip to content

[5.3] better use str_starts_with#44998

Merged
HLeithner merged 1 commit intojoomla:5.3-devfrom
heelc29:5.3/follow-44875
Feb 26, 2025
Merged

[5.3] better use str_starts_with#44998
HLeithner merged 1 commit intojoomla:5.3-devfrom
heelc29:5.3/follow-44875

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Feb 24, 2025

Follow-Pull Request for #44875 and #44938
@joomdonation

Summary of Changes

Better use str_starts_with if a substr command (or concatenate string) comes after it

Testing Instructions

code review?

Actual result BEFORE applying this Pull Request

?

Expected result AFTER applying this Pull Request

better checked string before perform action

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 7cfaf0a

Yes, it's better. Thanks @heelc29


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44998.

@QuyTon
Copy link
Contributor

QuyTon commented Feb 25, 2025

I have tested this item ✅ successfully on 7cfaf0a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44998.

@QuyTon
Copy link
Contributor

QuyTon commented Feb 25, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44998.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 25, 2025
@HLeithner HLeithner merged commit ced9cfe into joomla:5.3-dev Feb 26, 2025
4 checks passed
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 26, 2025
@QuyTon QuyTon added this to the Joomla! 5.3.0 milestone Feb 26, 2025
janschoenherr pushed a commit to janschoenherr/joomla-cms that referenced this pull request Mar 10, 2025
@heelc29 heelc29 deleted the 5.3/follow-44875 branch March 15, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants