[5.3] better use str_starts_with#44998
Merged
HLeithner merged 1 commit intojoomla:5.3-devfrom Feb 26, 2025
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 7cfaf0a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44998. |
Contributor
|
I have tested this item ✅ successfully on 7cfaf0a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44998. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44998. |
Member
|
thx |
janschoenherr
pushed a commit
to janschoenherr/joomla-cms
that referenced
this pull request
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-Pull Request for #44875 and #44938
@joomdonation
Summary of Changes
Better use
str_starts_withif asubstrcommand (or concatenate string) comes after itTesting Instructions
code review?
Actual result BEFORE applying this Pull Request
?
Expected result AFTER applying this Pull Request
better checked string before perform action
Link to documentations
Please select: