Skip to content

[5.2] Set column alias for BannerTable, fix warning on Save As Copy#44864

Merged
pe7er merged 3 commits intojoomla:5.2-devfrom
joomdonation:fix_warning_save_as_copy_banner
Feb 20, 2025
Merged

[5.2] Set column alias for BannerTable, fix warning on Save As Copy#44864
pe7er merged 3 commits intojoomla:5.2-devfrom
joomdonation:fix_warning_save_as_copy_banner

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue #44863.

Summary of Changes

This PR fixes small issue reported as #44863

Testing Instructions

Actual result BEFORE applying this Pull Request

  • There is warning on PHP error log when Save As Copy a banner

Expected result AFTER applying this Pull Request

  • No warning anymore

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@QuyTon
Copy link
Contributor

QuyTon commented Feb 12, 2025

I have tested this item ✅ successfully on 011724e

Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44864.

@ghost
Copy link

ghost commented Feb 12, 2025

I have tested this item ✅ successfully on 011724e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44864.

@alikon
Copy link
Contributor

alikon commented Feb 12, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44864.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 12, 2025
@pe7er pe7er enabled auto-merge (squash) February 20, 2025 16:08
@pe7er pe7er merged commit ec31a42 into joomla:5.2-dev Feb 20, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 20, 2025
@QuyTon QuyTon added this to the Joomla! 5.2.5 milestone Feb 20, 2025
@pe7er
Copy link
Contributor

pe7er commented Feb 20, 2025

Thanks @joomdonation !

@joomdonation
Copy link
Contributor Author

Thanks !

@joomdonation joomdonation deleted the fix_warning_save_as_copy_banner branch February 21, 2025 00:22
@richard67 richard67 mentioned this pull request Mar 6, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants