Conversation
Collaborator
mslipper
commented
Apr 28, 2022
mslipper
commented
- ci: Remove old nightly (ci: Remove old nightly #2451)
- update fakecontract creation using smock (update fakecontract creation using smock #2342)
- Added external mainnet 0.5.17 replica (Added external mainnet 0.5.17 replica #2453)
- docs: reentrancy protection comment on L2 messenger (docs: reentrancy protection comment on L2 messenger #2457)
- fix(rhc): bug when target leads reference (fix(rhc): bug when target leads reference #2456)
- fix(ci): no changeset nag for ts tests (fix(ci): no changeset nag for ts tests #2461)
- maint(ct): clean up CTC gas tests (maint(ct): clean up CTC gas tests #2462)
- maint(ct): clean up CSC tests (maint(ct): clean up CSC tests #2463)
- maint(ct): clean up deposit gas spec tests (maint(ct): clean up deposit gas spec tests #2460)
- maint(ct): clean up L1XDM tests (maint(ct): clean up L1XDM tests #2459)
- maint(ct): clean up L1StandardBridge tests (maint(ct): clean up L1StandardBridge tests #2458)
- ci: Respect do not merge tag in mergify (ci: Respect do not merge tag in mergify #2465)
- ci: Fix mergify config
- fix(sdk): use correct overrides type (fix(sdk): use correct overrides type #2468)
- maint(ct): clean up BondManager tests (maint(ct): clean up BondManager tests #2474)
- maint(ct): clean up Teleportr tests (maint(ct): clean up Teleportr tests #2473)
- proxyd: Limit the number of concurrent RPCs to backends (proxyd: Limit the number of concurrent RPCs to backends #2464)
- proxyd: Log sanitized RPC requests (proxyd: Log sanitized RPC requests #2470)
- maint(ct): clean up CTC tests (maint(ct): clean up CTC tests #2472)
- maint(ct): clean up L2xDM tests (maint(ct): clean up L2xDM tests #2475)
- integration-tests: Add tests for system addrs on verifiers/replicas (integration-tests: Add tests for system addrs on verifiers/replicas #2478)
- ci: Nightly release builds (ci: Nightly release builds #2479)
- ci: Rename docker env var, specify optimism context (ci: Rename docker env var, specify optimism context #2482)
- ci: Update remote docker version (ci: Update remote docker version #2487)
- dtl: fix openapi (dtl: fix openapi #2490)
- teleportr: Use L2 gas price (teleportr: Use L2 gas price #2484)
- Added kustomize deployment for goerli-nightly replica (Added kustomize deployment for goerli-nightly replica #2486)
- indexer: fix context reuse in bridge filter query (indexer: fix context reuse in bridge filter query #2496)
- maint(ct): clean up OVM_ETH tests (maint(ct): clean up OVM_ETH tests #2493)
- maint(ct): clean up L2StdTokenFac tests (maint(ct): clean up L2StdTokenFac tests #2492)
- Added SCC TotalElement collection for metrics (Added SCC TotalElement collection for metrics #2353)
- maint(ct): clean up L2StdBridge tests (maint(ct): clean up L2StdBridge tests #2491)
- l2geth: fix log.Crit usage (l2geth: fix log.Crit usage #2495)
- maint(ct): clean up GPO tests (maint(ct): clean up GPO tests #2494)
- indexer: Add airdrop API (indexer: Add airdrop API #2498)
- l2geth: Record rollup transaction metrics (l2geth: Record rollup transaction metrics #2497)
- maint(ct): clean up SCC tests (maint(ct): clean up SCC tests #2499)
- proxyd: Reduce RPC request logging (proxyd: Reduce RPC request logging #2502)
Now that we've deployed a new nightly cluster, we don't need these Circle configs anymore. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* update fakecontract creation using smock * fix lint errors * fix linters issues Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Added exteranl mainnet 0.5.17 replica * Update replicas to use new healthcheck script Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fixes a bug that would cause the healthcheck service not to properly check blocks when the target is advancing faster than the reference client. RHC will now check the block correpsonding to the lesser of the two block heights. Also adds a new metric to track the height difference in the two providers which could be used to alert if the target leads the reference by too much or vice versa. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Modifies mergify.yml to no longer yell at me to add a changeset when a PR only modifies .spec.ts files.
Another test cleanup PR, this time targeting the CTC gas tests. I'm going to keep doing this as separate PRs because: 1. These are simple changes 2. They *look* complicated because there are a lot of them Putting these into different PRs means they'll be easier to review and I'll have to do less shepherding over relatively minor PRs. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Yet another test cleanup commit. Cleans up the ChainStorageContainer tests with the same techniques as the previous commits along the same lines. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cleans up the L1CrossDomainMessenger tests using the new deploy function. Removes some unnecessary code. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cleans up tests for the L1StandardBridge. Removes a lot of unnecessary code and simplifies certain tests by bundling things into a single assertion. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
The config was invalid, and we reached the maximum number of nested rules.
ci: Fix mergify config
Replaces Overrides with CallOverrides for estimateGas functions so you can specify the "from" address. Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Cleans up BondManager tests using same techniques as previous test cleanup PRs.
Cleans up the TeleportrDeposit tests using the same techniques as previous cleanup PRs. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* proxyd: Limit the number of concurrent RPCs to backends We add a new config `max_concurrent_rpcs` under the server section to prevent too many RPC requests, (and, more loosely, the number of connections), from being sent upstream. Requests will block, in a FIFO fashion, until the number of in-flight RPCs is under the limit. * fix typo Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cleans up the CTC tests using the same techniques as used in other previous test cleanups. Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Cleans up the L2CrossDomainMessenger tests in the same manner as previous cleanup PRs. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…2478) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* ci: Nightly release builds * fix typo * ci: use nightly image tag Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* ci: Update remote docker version The nightly CI fails because default remote docker (17.09.0-ce) does not support DOCKER_BUILDKIT. Updating the remote docker version to be at least 18.09 fixes this. * Kick build, fix whitespace Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Added kustomize deployment for goerli-nightly replica * Updated replica-healthcheck to v1 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* fix (indexer): bridge filter query - fix ctx reuse * changeset: indexer patch - fix context reuse
Cleans up OVM_ETH tests using the same techniques as other cleanup PRs. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cleans up the L2StandardTokenFactory tests using the same technique as previous cleanup PRs. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Added SCC TotalElement collection for metrics * Update addressTotalElementsCallStatus metric name Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cleans up the L2StandardBridge tests using the same techniques as previous cleanup PRs. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* l2geth: fix log.Crit usage * add changeset * changed changeset: minor -> patch Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cleans up OVM_GasPriceOracle tests using the same techniques as other test cleanup PRs. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Add new metrics for transaction execution. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cleans up the StateCommitmentChain tests using the same techniques as used in previous test cleanups. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Logging the entire RPC request can be too "expensive" when logging request objects in a large JSON-RPC batch request. We log the raw HTTP request body instead so we can truncate effectively when the entire body exceeds the maxLogLength.
🦋 Changeset detectedLatest commit: d9f058c The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
C-protocol-critical
cfromknecht
approved these changes
Apr 28, 2022
Inphi
approved these changes
Apr 28, 2022
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
…vels (#2504) This PR addresses the tracing logs cleanup requirements by systematically improving logging across the codebase to ensure consistency and proper error reporting. ## Changes Made ### ✅ Added proper targets to log statements - **Examples**: Added targets to discovery, gossip, and execution-fixture examples (10+ fixes) - **Protocol**: Fixed all batch span validation logs with `batch_span` target (22 fixes) - **Node P2P**: Added `p2p_rpc` and `discv5_handler` targets to networking logs (7 fixes) - **Binaries**: Added targets to supervisor, host, and node command logs (6 fixes) - **Core Libraries**: Fixed hint processing and boot loading logs (2 fixes) ### ✅ Ensured error/warn logs include proper error cause information - Verified existing error logs already follow best practices with `{e}` formatting - Maintained error variant reporting in existing logs - Added error context where previously missing ### ✅ Adjusted log levels appropriately - Changed non-critical discovery metrics from `INFO` to `DEBUG` - Changed peer count logging from `INFO` to `DEBUG` - Changed gossip configuration details from `INFO` to `DEBUG` - Kept crucial system state information at `INFO` level ### ✅ Added missing major codepath logging - Added debug logging for successful boot information loading - Enhanced error reporting in critical paths ## Examples **Before:** ```rust warn!("batch exceeded sequencer time drift, sequencer must adopt new L1 origin"); info!("Discovery metrics: {:?}", metrics); error!("Failed to route hint: {e}"); ``` **After:** ```rust warn!(target: "batch_span", "batch exceeded sequencer time drift, sequencer must adopt new L1 origin"); debug!(target: "discovery", "Discovery metrics: {:?}", metrics); error!(target: "hint_reader", "Failed to route hint: {e}"); ``` ## Impact - **45+ log statements** improved across critical components - Consistent target naming conventions established (`batch_span`, `p2p_rpc`, `discovery`, etc.) - Better log filtering and debugging capabilities - Appropriate log levels reduce noise in production while maintaining visibility into system state - Error logs maintain full error context for debugging The patterns established provide a clear template for addressing the remaining log statements throughout the codebase in future iterations. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: theochap <80177219+theochap@users.noreply.github.com> Co-authored-by: refcell <abigger87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.