maint(ct): clean up L2StdBridge tests#2491
Merged
mergify[bot] merged 2 commits intodevelopfrom Apr 24, 2022
Merged
Conversation
Cleans up the L2StandardBridge tests using the same techniques as previous cleanup PRs.
|
mslipper
approved these changes
Apr 22, 2022
tynes
approved these changes
Apr 24, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
Cleans up the L2StandardBridge tests using the same techniques as previous cleanup PRs. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Merged
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Summary
Adds comprehensive documentation for all rollup RPC methods in the
`docs/` directory, following the established format of the P2P RPC
documentation.
## Changes
- **Replaced placeholder content** in
`docs/docs/pages/node/rpc/rollup.mdx` with complete documentation
- **Documented all 4 supported rollup RPC methods** with detailed
specifications:
- `optimism_outputAtBlock` - Get output root and block info at specific
block
- `optimism_syncStatus` - Get comprehensive L1/L2 synchronization status
- `optimism_rollupConfig` - Get complete rollup configuration parameters
- `optimism_version` - Get Kona software version
- **Documented deprecated method** `optimism_safeHeadAtL1Block` as
unsupported with explanation
- **Added comprehensive examples** with realistic JSON-RPC
request/response pairs
- **Included parameter and return type specifications** for all methods
## Documentation Quality
✅ **Follows established patterns** - Uses same structure and format as
existing P2P RPC docs
✅ **Method signatures verified** - Confirmed against trait definitions
in `crates/node/rpc/src/jsonrpsee.rs`
✅ **Implementation validated** - Cross-referenced with actual usage in
test files
✅ **Complete coverage** - Documents all methods found in
`RollupNodeApiServer` trait
✅ **Properly integrated** - Already listed in sidebar navigation and
overview
## Before/After
**Before:**
```markdown
# Rollup RPC Methods
Coming soon...
```
**After:** 354 lines of comprehensive documentation including:
- Detailed method descriptions and purpose
- Parameter specifications with types and valid values
- Complete response structure documentation
- Realistic JSON-RPC examples for each method
- Clear indication of unsupported methods with explanations
## Example Usage
The documentation now provides clear guidance for developers:
```bash
# Get current sync status
curl -X POST -H "Content-Type: application/json" \
--data '{"jsonrpc":"2.0","id":1,"method":"optimism_syncStatus","params":[]}' \
http://localhost:8545
# Get output at latest block
curl -X POST -H "Content-Type: application/json" \
--data '{"jsonrpc":"2.0","id":1,"method":"optimism_outputAtBlock","params":["latest"]}' \
http://localhost:8545
```
Closes the documentation gap for rollup RPC methods and provides
developers with complete reference material for interacting with Kona's
rollup functionality.
<!-- START COPILOT CODING AGENT TIPS -->
---
💬 Share your feedback on Copilot coding agent for the chance to win a
$200 gift card! Click
[here](https://survey.alchemer.com/s3/8343779/Copilot-Coding-agent) to
start the survey.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: refcell <21288394+refcell@users.noreply.github.com>
Co-authored-by: refcell <abigger87@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleans up the L2StandardBridge tests using the same techniques as
previous cleanup PRs.