Skip to content

l2geth: fix log.Crit usage#2495

Merged
mergify[bot] merged 4 commits intoethereum-optimism:developfrom
modagi:bugfix/log-usage
Apr 24, 2022
Merged

l2geth: fix log.Crit usage#2495
mergify[bot] merged 4 commits intoethereum-optimism:developfrom
modagi:bugfix/log-usage

Conversation

@modagi
Copy link
Contributor

@modagi modagi commented Apr 23, 2022

fix log.Crit usage

log.Crit("Sequencer cannot sync transactions to tip: %w", err)
log.Crit("Sequencer cannot sync queue to tip: %w", err)

->

log.Crit("Sequencer cannot sync transactions to tip", "err", err)
log.Crit("Sequencer cannot sync queue to tip", "err", err)

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2022

🦋 Changeset detected

Latest commit: c4d43a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/l2geth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers C-protocol-critical Category: Modifies protocol-critical code A-cannon Area: cannon labels Apr 23, 2022
@mergify mergify bot requested review from Inphi and cfromknecht April 23, 2022 06:23
@mergify
Copy link
Contributor

mergify bot commented Apr 23, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify mergify bot requested a review from tynes April 23, 2022 06:23
@modagi modagi requested a review from tynes April 23, 2022 20:39
@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 935a98e into ethereum-optimism:develop Apr 24, 2022
nebojsa94 pushed a commit to Tenderly/optimism that referenced this pull request Apr 26, 2022
* l2geth: fix log.Crit usage

* add changeset

* changed changeset: minor -> patch

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@mslipper mslipper mentioned this pull request Apr 28, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
Closes #2495

---------

Co-authored-by: sadiq1971 <sadiqurr8@gmail.com>
theochap pushed a commit that referenced this pull request Jan 14, 2026
Closes #2495

---------

Co-authored-by: sadiq1971 <sadiqurr8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cannon Area: cannon C-protocol-critical Category: Modifies protocol-critical code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants