Skip to content

Comments

maint(ct): clean up L1XDM tests#2459

Merged
mergify[bot] merged 2 commits intodevelopfrom
sc/ct-test-cleanup-2
Apr 14, 2022
Merged

maint(ct): clean up L1XDM tests#2459
mergify[bot] merged 2 commits intodevelopfrom
sc/ct-test-cleanup-2

Conversation

@smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Apr 14, 2022

Description
Cleans up the L1CrossDomainMessenger tests using the new deploy
function. Removes some unnecessary code.

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9cec1f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from cfromknecht and tuxcanfly April 14, 2022 01:21
@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@smartcontracts
Copy link
Contributor Author

smartcontracts commented Apr 14, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

No changeset needed for test changes.

smartcontracts added a commit that referenced this pull request Apr 14, 2022
@smartcontracts
maint(ct): clean up deposit gas spec tests
4bc664d 
Cleans up the deposit gas spec tests using the same techniques as found
in #2458 and #2459.
@smartcontracts smartcontracts mentioned this pull request Apr 14, 2022
Merged
@smartcontracts
maint(ct): clean up L1XDM tests
7be2ca1 
Cleans up the L1CrossDomainMessenger tests using the new deploy
function. Removes some unnecessary code.
maurelian
maurelian approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no change in functionality tested. LGTM

@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2022

This PR has been added to the merge queue, and will be merged soon.

mergify bot added a commit that referenced this pull request Apr 14, 2022
@smartcontracts @mergify
maint(ct): clean up deposit gas spec tests (#2460)
c74f75b 
Cleans up the deposit gas spec tests using the same techniques as found
in #2458 and #2459.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 2925b1d into develop Apr 14, 2022
@mergify mergify bot deleted the sc/ct-test-cleanup-2 branch April 14, 2022 19:01
nebojsa94 pushed a commit to Tenderly/optimism that referenced this pull request Apr 26, 2022
@smartcontracts @mergify @nebojsa94
maint(ct): clean up deposit gas spec tests (ethereum-optimism#2460)
a579fc5 
Cleans up the deposit gas spec tests using the same techniques as found
in ethereum-optimism#2458 and ethereum-optimism#2459.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nebojsa94 pushed a commit to Tenderly/optimism that referenced this pull request Apr 26, 2022
@smartcontracts @mergify @nebojsa94
maint(ct): clean up L1XDM tests (ethereum-optimism#2459)
0700701 
Cleans up the L1CrossDomainMessenger tests using the new deploy
function. Removes some unnecessary code.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@mslipper mslipper mentioned this pull request Apr 28, 2022
Merged
theochap pushed a commit that referenced this pull request Dec 10, 2025
@refcell
fix(docs): Front Page (#2459)
2643e43 
### Description

Touches up the front page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@maurelian maurelian maurelian approved these changes

@cfromknecht cfromknecht Awaiting requested review from cfromknecht

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smartcontracts @tynes @maurelian