proxyd: Limit the number of concurrent RPCs to backends#2464
Merged
mergify[bot] merged 3 commits intoethereum-optimism:developfrom Apr 15, 2022
Merged
proxyd: Limit the number of concurrent RPCs to backends#2464mergify[bot] merged 3 commits intoethereum-optimism:developfrom
mergify[bot] merged 3 commits intoethereum-optimism:developfrom
Conversation
We add a new config `max_concurrent_rpcs` under the server section to prevent too many RPC requests, (and, more loosely, the number of connections), from being sent upstream. Requests will block, in a FIFO fashion, until the number of in-flight RPCs is under the limit.
🦋 Changeset detectedLatest commit: b8f8d15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mslipper
requested changes
Apr 14, 2022
mslipper
approved these changes
Apr 14, 2022
tynes
approved these changes
Apr 15, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
…imism#2464) * proxyd: Limit the number of concurrent RPCs to backends We add a new config `max_concurrent_rpcs` under the server section to prevent too many RPC requests, (and, more loosely, the number of connections), from being sent upstream. Requests will block, in a FIFO fashion, until the number of in-flight RPCs is under the limit. * fix typo Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add a new config
max_concurrent_rpcsunder the server section toprevent too many RPC requests. This also sets a limit on the number of open connections to upstream.
However, due to connection reuse, there can be less connections in-use than concurrent RPCs.
Requests are blocked, in a FIFO fashion, until the number of in-flight RPCs is under the limit.