fix(rhc): bug when target leads reference#2456
Merged
mergify[bot] merged 2 commits intodevelopfrom Apr 13, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: f4bc244 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Fixes a bug that would cause the healthcheck service not to properly check blocks when the target is advancing faster than the reference client. RHC will now check the block correpsonding to the lesser of the two block heights. Also adds a new metric to track the height difference in the two providers which could be used to alert if the target leads the reference by too much or vice versa.
smartcontracts
force-pushed
the
sc/fix-healthcheck-bug-1
branch
from
ceed8ce to
7f33ae6
Compare
smartcontracts
commented
Apr 13, 2022
tynes
approved these changes
Apr 13, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
Fixes a bug that would cause the healthcheck service not to properly check blocks when the target is advancing faster than the reference client. RHC will now check the block correpsonding to the lesser of the two block heights. Also adds a new metric to track the height difference in the two providers which could be used to alert if the target leads the reference by too much or vice versa. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug that would cause the healthcheck service not to properly
check blocks when the target is advancing faster than the reference
client. RHC will now check the block correpsonding to the lesser of the
two block heights. Also adds a new metric to track the height difference
in the two providers which could be used to alert if the target leads
the reference by too much or vice versa.
Metadata