integration-tests: Add tests for system addrs on verifiers/replicas#2478
Merged
mergify[bot] merged 2 commits intoethereum-optimism:developfrom Apr 18, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 8a49ec8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mslipper
force-pushed
the
feat/replica-system-addr-tests
branch
3 times, most recently
from
4246c8f to
febc309
Compare
mslipper
force-pushed
the
feat/replica-system-addr-tests
branch
from
febc309 to
3126126
Compare
Inphi
approved these changes
Apr 18, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
tynes
approved these changes
Apr 18, 2022
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
…thereum-optimism#2478) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Merged
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Problem The `README.md` file in the `kona-peers` crate had improper markdown formatting that made it difficult to read and inconsistent with other crates in the repository: - Malformed title starting with `1.#` instead of proper markdown header - Content was written as Rust doc comments (`//!`) rather than markdown - Missing standard badge links present in other crate READMEs - Overall inconsistent formatting compared to repository standards ## Solution Fixed the markdown formatting to match the consistent pattern used across other crates in the repository: 1. **Fixed title**: Changed `1.#` to proper markdown header `# \`kona-peers\`` 2. **Added standard badges**: Added CI, crates.io, license, and codecov badge links following the same pattern as other crates 3. **Converted doc comments**: Removed Rust doc comment syntax (`//!`) and converted content to proper markdown paragraphs 4. **Preserved technical content**: Maintained all the comprehensive documentation about networking utilities, node records, peer IDs, and ENRs ## Before ```markdown 1.# //! Networking Utilities ported from reth. //! //! Much of this module is ported from //! <https://github.com/paradigmxyz/reth/blob/...>. //! //! This module manages and converts Ethereum network entities... ``` ## After ```markdown # `kona-peers` <a href="https://github.com/op-rs/kona/actions/workflows/rust_ci.yaml">...</a> <a href="https://crates.io/crates/kona-peers">...</a> <a href="https://github.com/op-rs/kona/blob/main/LICENSE.md">...</a> <a href="https://img.shields.io/codecov/c/github/op-rs/kona">...</a> Networking Utilities ported from reth. Much of this module is ported from <https://github.com/paradigmxyz/reth/blob/...>. This module manages and converts Ethereum network entities... ``` The README now properly renders as markdown and follows the consistent formatting pattern established by other crates in the repository, while preserving all the valuable technical documentation about the different node record types (`PeerId`, `NodeRecord`, `discv5::Enr`, `AnyNode`). <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey.alchemer.com/s3/8343779/Copilot-Coding-agent) to start the survey. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: refcell <21288394+refcell@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.