maint(ct): clean up L2StdTokenFac tests#2492
Merged
mergify[bot] merged 2 commits intodevelopfrom Apr 24, 2022
Merged
Conversation
Cleans up the L2StandardTokenFactory tests using the same technique as previous cleanup PRs.
|
tynes
approved these changes
Apr 22, 2022
mslipper
approved these changes
Apr 24, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
tynes
approved these changes
Apr 24, 2022
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
Cleans up the L2StandardTokenFactory tests using the same technique as previous cleanup PRs. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Merged
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
…instructions (#2492) ## Summary Completely rewrote the `bin/node/README.md` to provide comprehensive documentation for the `kona-node` binary, addressing the need for clear installation and usage instructions. ## Changes ### Before The README was minimal (8 lines) with only a basic description: ```markdown # `kona-node` A binary that runs OP Stack consensus. Subcommands include: - gossip using [`kona-p2p`](https://crates.io/crates/kona-p2p) - discovery using [`kona-p2p`](https://crates.io/crates/kona-p2p) ``` ### After Expanded to 149 lines of comprehensive documentation including: - **Installation instructions** using `cargo install kona-node` - **Complete usage examples** derived from the docker recipe configuration - **All available subcommands** with aliases (node, net, registry, bootstore, info) - **Working OP Sepolia configuration example** - **Environment variable configuration** options - **Help menu references** for all commands - **Requirements section** listing prerequisites - **Advanced configuration** reference ## Key Features Added ### 🛠️ Installation ```bash cargo install kona-node ``` ### 📖 Usage Examples Complete command structure with real-world OP Sepolia example: ```bash kona-node \ --l2-chain-id 11155420 \ --metrics.enabled \ node \ --l1 $L1_PROVIDER_RPC \ --l1-beacon $L1_BEACON_API \ --l2 http://localhost:8551 \ --rpc.port 5060 ``` ### 🔧 Environment Variables Documented all major configuration options: - `KONA_NODE_L1_ETH_RPC` - `KONA_NODE_L1_BEACON` - `KONA_NODE_L2_ENGINE_RPC` - `RUST_LOG` ### 📚 Help References Clear instructions to access help menus: ```bash kona-node --help kona-node node --help ``` ## Implementation Notes The documentation was created by analyzing: - Docker recipe configuration in `docker/recipes/kona-node/docker-compose.yaml` - CLI source code in `bin/node/src/cli.rs` and command definitions - Flag structures in `bin/node/src/flags/` for accurate parameter documentation This addresses the original request to "provide usage instructions by installing the `kona-node` with `cargo install`" and uses "the docker recipe for the `kona-node` to see how to run the `kona-node` binary with the specified arguments" while mentioning "you can use the help menu." <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey.alchemer.com/s3/8343779/Copilot-Coding-agent) to start the survey. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: refcell <21288394+refcell@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleans up the L2StandardTokenFactory tests using the same technique as
previous cleanup PRs.